From 7d6d5ed72200e1a41b7a89a5db37008b4a7de3af Mon Sep 17 00:00:00 2001 From: Marten Seemann Date: Thu, 22 Dec 2022 21:43:52 +1300 Subject: [PATCH] webtransport: initialize a NullResourceManager if none is provided --- p2p/transport/webtransport/transport.go | 3 +++ p2p/transport/webtransport/transport_test.go | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/p2p/transport/webtransport/transport.go b/p2p/transport/webtransport/transport.go index 98c92e7879..65c6c1402b 100644 --- a/p2p/transport/webtransport/transport.go +++ b/p2p/transport/webtransport/transport.go @@ -89,6 +89,9 @@ func New(key ic.PrivKey, psk pnet.PSK, connManager *quicreuse.ConnManager, gater log.Error("WebTransport doesn't support private networks yet.") return nil, errors.New("WebTransport doesn't support private networks yet") } + if rcmgr == nil { + rcmgr = &network.NullResourceManager{} + } id, err := peer.IDFromPrivateKey(key) if err != nil { return nil, err diff --git a/p2p/transport/webtransport/transport_test.go b/p2p/transport/webtransport/transport_test.go index c2b0448b9a..2e5e045d3f 100644 --- a/p2p/transport/webtransport/transport_test.go +++ b/p2p/transport/webtransport/transport_test.go @@ -107,7 +107,7 @@ func newConnManager(t *testing.T, opts ...quicreuse.Option) *quicreuse.ConnManag func TestTransport(t *testing.T) { serverID, serverKey := newIdentity(t) - tr, err := libp2pwebtransport.New(serverKey, nil, newConnManager(t), nil, &network.NullResourceManager{}) + tr, err := libp2pwebtransport.New(serverKey, nil, newConnManager(t), nil, nil) require.NoError(t, err) defer tr.(io.Closer).Close() ln, err := tr.Listen(ma.StringCast("/ip4/127.0.0.1/udp/0/quic-v1/webtransport")) @@ -117,7 +117,7 @@ func TestTransport(t *testing.T) { addrChan := make(chan ma.Multiaddr) go func() { _, clientKey := newIdentity(t) - tr2, err := libp2pwebtransport.New(clientKey, nil, newConnManager(t), nil, &network.NullResourceManager{}) + tr2, err := libp2pwebtransport.New(clientKey, nil, newConnManager(t), nil, nil) require.NoError(t, err) defer tr2.(io.Closer).Close()