Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

identify: TestObsAddrSet is flaky #938

Closed
aarshkshah1992 opened this issue May 19, 2020 · 1 comment · Fixed by #1984
Closed

identify: TestObsAddrSet is flaky #938

aarshkshah1992 opened this issue May 19, 2020 · 1 comment · Fixed by #1984
Assignees
@MarcoPolo
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@aarshkshah1992
Copy link
Contributor

Looks like a regression. Need to investigate.

https://travis-ci.com/github/libp2p/go-libp2p/builds/166912970.
@aarshkshah1992 aarshkshah1992 added the kind/bug A bug in existing code (including security flaws) label May 19, 2020
@aarshkshah1992 aarshkshah1992 self-assigned this May 19, 2020
@aarshkshah1992 aarshkshah1992 mentioned this issue May 19, 2020
Closed
@marten-seemann marten-seemann changed the title TestObsAddrSet is flaky identify: TestObsAddrSet is flaky Jul 1, 2022
@marten-seemann
Copy link
Contributor

https://github.com/libp2p/go-libp2p/runs/7153635906?check_suite_focus=true

 === RUN   TestObsAddrSet
  2022-07-01T16:37:09.347Z	DEBUG	net/identify	identify/obsaddr.go:397	added own observed listen addr	{"observed": "/ip4/1.2.3.4/tcp/1231"}
  2022-07-01T16:37:09.347Z	DEBUG	net/identify	identify/id.go:408	/ipfs/id/1.0.0 sent message to Qmaj3Hr7dGd4MJGqPSFGvXDhvJZzyHdFFDpX3SEvyPHDdF /ip4/127.0.0.1/tcp/10086
  2022-07-01T16:37:09.347Z	DEBUG	net/identify	identify/id.go:440	/ipfs/id/1.0.0 received message from QmXDu4V9B1CD3LqGr7xrMQygeSHPTzu9ZC7rYH96owVPcC /ip4/1.2.3.4/tcp/1234
  2022-07-01T16:37:09.347Z	DEBUG	net/identify	identify/id.go:636	Qmaj3Hr7dGd4MJGqPSFGvXDhvJZzyHdFFDpX3SEvyPHDdF received listen addrs for QmXDu4V9B1CD3LqGr7xrMQygeSHPTzu9ZC7rYH96owVPcC: [/ip4/1.2.3.4/tcp/1234]
  2022-07-01T16:37:09.347Z	DEBUG	net/identify	identify/id.go:408	/ipfs/id/1.0.0 sent message to QmXDu4V9B1CD3LqGr7xrMQygeSHPTzu9ZC7rYH96owVPcC /ip4/1.2.3.4/tcp/1234
  2022-07-01T16:37:09.347Z	DEBUG	net/identify	identify/id.go:440	/ipfs/id/1.0.0 received message from Qmaj3Hr7dGd4MJGqPSFGvXDhvJZzyHdFFDpX3SEvyPHDdF /ip4/127.0.0.1/tcp/10086
  2022-07-01T16:37:09.348Z	DEBUG	net/identify	identify/id.go:636	QmXDu4V9B1CD3LqGr7xrMQygeSHPTzu9ZC7rYH96owVPcC received listen addrs for Qmaj3Hr7dGd4MJGqPSFGvXDhvJZzyHdFFDpX3SEvyPHDdF: [/ip4/127.0.0.1/tcp/10086]
  2022-07-01T16:37:09.348Z	DEBUG	net/identify	identify/obsaddr.go:397	added own observed listen addr	{"observed": "/ip4/1.2.3.4/tcp/1234"}
  2022-07-01T16:37:09.435Z	DEBUG	net/identify	identify/obsaddr.go:397	added own observed listen addr	{"observed": "/ip4/1.2.3.4/tcp/1232"}
  2022-07-01T16:37:09.493Z	DEBUG	net/identify	identify/obsaddr.go:397	added own observed listen addr	{"observed": "/ip4/1.2.3.4/tcp/1233"}
  2022-07-01T16:37:09.563Z	DEBUG	net/identify	identify/obsaddr.go:397	added own observed listen addr	{"observed": "/ip4/1.2.3.4/tcp/1231"}
  2022-07-01T16:37:09.653Z	DEBUG	net/identify	identify/obsaddr.go:397	added own observed listen addr	{"observed": "/ip4/1.2.3.4/tcp/1232"}
  2022-07-01T16:37:09.774Z	DEBUG	net/identify	identify/obsaddr.go:397	added own observed listen addr	{"observed": "/ip4/1.2.3.4/tcp/1233"}
  2022-07-01T16:37:09.898Z	DEBUG	net/identify	identify/obsaddr.go:397	added own observed listen addr	{"observed": "/ip4/1.2.3.4/tcp/1231"}
  2022-07-01T16:37:09.898Z	DEBUG	net/identify	identify/id.go:408	/ipfs/id/1.0.0 sent message to Qmaj3Hr7dGd4MJGqPSFGvXDhvJZzyHdFFDpX3SEvyPHDdF /ip4/127.0.0.1/tcp/10086
  2022-07-01T16:37:09.898Z	DEBUG	net/identify	identify/id.go:408	/ipfs/id/1.0.0 sent message to QmfWYWjh4zem3fvjJtcuAhwbRXpf1zRQxgZ5TqgnyLMVWv /ip4/1.2.3.4/tcp/1235
  2022-07-01T16:37:09.898Z	DEBUG	net/identify	identify/id.go:440	/ipfs/id/1.0.0 received message from QmfWYWjh4zem3fvjJtcuAhwbRXpf1zRQxgZ5TqgnyLMVWv /ip4/1.2.3.4/tcp/1235
  2022-07-01T16:37:09.898Z	DEBUG	net/identify	identify/id.go:636	Qmaj3Hr7dGd4MJGqPSFGvXDhvJZzyHdFFDpX3SEvyPHDdF received listen addrs for QmfWYWjh4zem3fvjJtcuAhwbRXpf1zRQxgZ5TqgnyLMVWv: [/ip4/1.2.3.4/tcp/1235]
  2022-07-01T16:37:09.898Z	DEBUG	net/identify	identify/id.go:440	/ipfs/id/1.0.0 received message from Qmaj3Hr7dGd4MJGqPSFGvXDhvJZzyHdFFDpX3SEvyPHDdF /ip4/127.0.0.1/tcp/10086
  2022-07-01T16:37:09.898Z	DEBUG	net/identify	identify/id.go:636	QmfWYWjh4zem3fvjJtcuAhwbRXpf1zRQxgZ5TqgnyLMVWv received listen addrs for Qmaj3Hr7dGd4MJGqPSFGvXDhvJZzyHdFFDpX3SEvyPHDdF: [/ip4/127.0.0.1/tcp/10086]
  2022-07-01T16:37:09.899Z	DEBUG	net/identify	identify/obsaddr.go:397	added own observed listen addr	{"observed": "/ip4/1.2.3.4/tcp/1235"}
  2022-07-01T16:37:09.954Z	DEBUG	net/identify	identify/obsaddr.go:397	added own observed listen addr	{"observed": "/ip4/1.2.3.4/tcp/1232"}
  2022-07-01T16:37:10.041Z	DEBUG	net/identify	identify/obsaddr.go:397	added own observed listen addr	{"observed": "/ip4/1.2.3.4/tcp/1233"}
  2022-07-01T16:37:10.092Z	DEBUG	net/identify	identify/obsaddr.go:397	added own observed listen addr	{"observed": "/ip4/1.2.3.4/tcp/1231"}
  2022-07-01T16:37:10.092Z	DEBUG	net/identify	identify/id.go:408	/ipfs/id/1.0.0 sent message to Qmaj3Hr7dGd4MJGqPSFGvXDhvJZzyHdFFDpX3SEvyPHDdF /ip4/127.0.0.1/tcp/10086
  2022-07-01T16:37:10.092Z	DEBUG	net/identify	identify/id.go:440	/ipfs/id/1.0.0 received message from QmegvjNzXPrEpubV4bdMdKGfh4bvKX8oSpWXLhrWrXoj2Q /ip4/1.2.3.6/tcp/1236
  2022-07-01T16:37:10.092Z	DEBUG	net/identify	identify/id.go:636	Qmaj3Hr7dGd4MJGqPSFGvXDhvJZzyHdFFDpX3SEvyPHDdF received listen addrs for QmegvjNzXPrEpubV4bdMdKGfh4bvKX8oSpWXLhrWrXoj2Q: [/ip4/1.2.3.6/tcp/1236]
  2022-07-01T16:37:10.093Z	DEBUG	net/identify	identify/id.go:408	/ipfs/id/1.0.0 sent message to QmegvjNzXPrEpubV4bdMdKGfh4bvKX8oSpWXLhrWrXoj2Q /ip4/1.2.3.6/tcp/1236
  2022-07-01T16:37:10.093Z	DEBUG	net/identify	identify/id.go:440	/ipfs/id/1.0.0 received message from Qmaj3Hr7dGd4MJGqPSFGvXDhvJZzyHdFFDpX3SEvyPHDdF /ip4/127.0.0.1/tcp/10086
  2022-07-01T16:37:10.093Z	DEBUG	net/identify	identify/id.go:636	QmegvjNzXPrEpubV4bdMdKGfh4bvKX8oSpWXLhrWrXoj2Q received listen addrs for Qmaj3Hr7dGd4MJGqPSFGvXDhvJZzyHdFFDpX3SEvyPHDdF: [/ip4/127.0.0.1/tcp/10086]
  2022-07-01T16:37:10.093Z	DEBUG	net/identify	identify/obsaddr.go:397	added own observed listen addr	{"observed": "/ip4/1.2.3.6/tcp/1236"}
  2022-07-01T16:37:10.197Z	DEBUG	net/identify	identify/obsaddr.go:397	added own observed listen addr	{"observed": "/ip4/1.2.3.4/tcp/1231"}
  2022-07-01T16:37:10.197Z	DEBUG	net/identify	identify/id.go:408	/ipfs/id/1.0.0 sent message to Qmaj3Hr7dGd4MJGqPSFGvXDhvJZzyHdFFDpX3SEvyPHDdF /ip4/127.0.0.1/tcp/10086
  2022-07-01T16:37:10.197Z	DEBUG	net/identify	identify/id.go:408	/ipfs/id/1.0.0 sent message to QmWzXopEqWyxARSb61onEtmY6pD7MVd72snCUnKuDS61YL /ip4/1.2.3.7/tcp/1237
  2022-07-01T16:37:10.197Z	DEBUG	net/identify	identify/id.go:440	/ipfs/id/1.0.0 received message from Qmaj3Hr7dGd4MJGqPSFGvXDhvJZzyHdFFDpX3SEvyPHDdF /ip4/127.0.0.1/tcp/10086
  2022-07-01T16:37:10.197Z	DEBUG	net/identify	identify/id.go:636	QmWzXopEqWyxARSb61onEtmY6pD7MVd72snCUnKuDS61YL received listen addrs for Qmaj3Hr7dGd4MJGqPSFGvXDhvJZzyHdFFDpX3SEvyPHDdF: [/ip4/127.0.0.1/tcp/10086]
  2022-07-01T16:37:10.197Z	DEBUG	net/identify	identify/id.go:440	/ipfs/id/1.0.0 received message from QmWzXopEqWyxARSb61onEtmY6pD7MVd72snCUnKuDS61YL /ip4/1.2.3.7/tcp/1237
  2022-07-01T16:37:10.197Z	DEBUG	net/identify	identify/id.go:636	Qmaj3Hr7dGd4MJGqPSFGvXDhvJZzyHdFFDpX3SEvyPHDdF received listen addrs for QmWzXopEqWyxARSb61onEtmY6pD7MVd72snCUnKuDS61YL: [/ip4/1.2.3.7/tcp/1237]
  2022-07-01T16:37:10.197Z	DEBUG	net/identify	identify/obsaddr.go:397	added own observed listen addr	{"observed": "/ip4/1.2.3.7/tcp/1237"}
  2022-07-01T16:37:10.273Z	DEBUG	net/identify	identify/obsaddr.go:397	added own observed listen addr	{"observed": "/ip4/1.2.3.4/tcp/1231"}
  2022-07-01T16:37:10.273Z	DEBUG	net/identify	identify/id.go:408	/ipfs/id/1.0.0 sent message to Qmaj3Hr7dGd4MJGqPSFGvXDhvJZzyHdFFDpX3SEvyPHDdF /ip4/127.0.0.1/tcp/10086
  2022-07-01T16:37:10.273Z	DEBUG	net/identify	identify/id.go:408	/ipfs/id/1.0.0 sent message to QmSJmZhSX4BiZqb2L9VYTPXJSxdSPcHQXxTQkJSgUA8BPx /ip4/1.2.3.8/tcp/1237
  2022-07-01T16:37:10.273Z	DEBUG	net/identify	identify/id.go:440	/ipfs/id/1.0.0 received message from Qmaj3Hr7dGd4MJGqPSFGvXDhvJZzyHdFFDpX3SEvyPHDdF /ip4/127.0.0.1/tcp/10086
  2022-07-01T16:37:10.273Z	DEBUG	net/identify	identify/id.go:636	QmSJmZhSX4BiZqb2L9VYTPXJSxdSPcHQXxTQkJSgUA8BPx received listen addrs for Qmaj3Hr7dGd4MJGqPSFGvXDhvJZzyHdFFDpX3SEvyPHDdF: [/ip4/127.0.0.1/tcp/10086]
  2022-07-01T16:37:10.273Z	DEBUG	net/identify	identify/id.go:440	/ipfs/id/1.0.0 received message from QmSJmZhSX4BiZqb2L9VYTPXJSxdSPcHQXxTQkJSgUA8BPx /ip4/1.2.3.8/tcp/1237
  2022-07-01T16:37:10.273Z	DEBUG	net/identify	identify/id.go:636	Qmaj3Hr7dGd4MJGqPSFGvXDhvJZzyHdFFDpX3SEvyPHDdF received listen addrs for QmSJmZhSX4BiZqb2L9VYTPXJSxdSPcHQXxTQkJSgUA8BPx: [/ip4/1.2.3.8/tcp/1237]
  2022-07-01T16:37:10.273Z	DEBUG	net/identify	identify/obsaddr.go:397	added own observed listen addr	{"observed": "/ip4/1.2.3.8/tcp/1237"}
  2022-07-01T16:37:10.378Z	DEBUG	net/identify	identify/obsaddr.go:397	added own observed listen addr	{"observed": "/ip4/1.2.3.4/tcp/1232"}
  2022-07-01T16:37:10.472Z	DEBUG	net/identify	identify/obsaddr.go:397	added own observed listen addr	{"observed": "/ip4/1.2.3.4/tcp/1231"}
  2022-07-01T16:37:10.561Z	DEBUG	net/identify	identify/obsaddr.go:397	added own observed listen addr	{"observed": "/ip4/1.2.3.4/tcp/1231"}
  2022-07-01T16:37:10.648Z	DEBUG	net/identify	identify/obsaddr.go:397	added own observed listen addr	{"observed": "/ip4/1.2.3.4/tcp/1232"}
  2022-07-01T16:37:10.773Z	DEBUG	net/identify	identify/obsaddr.go:397	added own observed listen addr	{"observed": "/ip4/1.2.3.4/tcp/1231"}
  2022-07-01T16:37:10.876Z	DEBUG	net/identify	identify/obsaddr.go:397	added own observed listen addr	{"observed": "/ip4/1.2.3.4/tcp/1231"}
  2022-07-01T16:37:10.926Z	DEBUG	net/identify	identify/obsaddr.go:397	added own observed listen addr	{"observed": "/ip4/1.2.3.4/tcp/1232"}
  2022-07-01T16:37:10.985Z	DEBUG	net/identify	identify/obsaddr.go:397	added own observed listen addr	{"observed": "/ip4/1.2.3.4/tcp/1231"}
  2022-07-01T16:37:11.038Z	DEBUG	net/identify	identify/obsaddr.go:397	added own observed listen addr	{"observed": "/ip4/1.2.3.4/tcp/1231"}
  2022-07-01T16:37:11.092Z	DEBUG	net/identify	identify/obsaddr.go:397	added own observed listen addr	{"observed": "/ip4/1.2.3.4/tcp/1232"}
  2022-07-01T16:37:11.093Z	DEBUG	net/identify	identify/id.go:408	/ipfs/id/1.0.0 sent message to Qmaj3Hr7dGd4MJGqPSFGvXDhvJZzyHdFFDpX3SEvyPHDdF /ip4/127.0.0.1/tcp/10086
  2022-07-01T16:37:11.093Z	DEBUG	net/identify	identify/id.go:440	/ipfs/id/1.0.0 received message from QmVhniwe9hC4P5Xw7AehAupGNYUcwdnx6uNAZsEQSWp5qy /ip4/1.2.3.9/tcp/1237
  2022-07-01T16:37:11.093Z	DEBUG	net/identify	identify/id.go:636	Qmaj3Hr7dGd4MJGqPSFGvXDhvJZzyHdFFDpX3SEvyPHDdF received listen addrs for QmVhniwe9hC4P5Xw7AehAupGNYUcwdnx6uNAZsEQSWp5qy: [/ip4/1.2.3.9/tcp/1237]
  2022-07-01T16:37:11.093Z	DEBUG	net/identify	identify/id.go:408	/ipfs/id/1.0.0 sent message to QmVhniwe9hC4P5Xw7AehAupGNYUcwdnx6uNAZsEQSWp5qy /ip4/1.2.3.9/tcp/1237
  2022-07-01T16:37:11.093Z	DEBUG	net/identify	identify/id.go:440	/ipfs/id/1.0.0 received message from Qmaj3Hr7dGd4MJGqPSFGvXDhvJZzyHdFFDpX3SEvyPHDdF /ip4/127.0.0.1/tcp/10086
  2022-07-01T16:37:11.093Z	DEBUG	net/identify	identify/id.go:636	QmVhniwe9hC4P5Xw7AehAupGNYUcwdnx6uNAZsEQSWp5qy received listen addrs for Qmaj3Hr7dGd4MJGqPSFGvXDhvJZzyHdFFDpX3SEvyPHDdF: [/ip4/127.0.0.1/tcp/10086]
  2022-07-01T16:37:11.093Z	DEBUG	net/identify	identify/obsaddr.go:397	added own observed listen addr	{"observed": "/ip4/1.2.3.9/tcp/1237"}
  2022-07-01T16:37:11.202Z	DEBUG	net/identify	identify/obsaddr.go:397	added own observed listen addr	{"observed": "/ip4/1.2.3.4/tcp/1232"}
  2022-07-01T16:37:11.202Z	DEBUG	net/identify	identify/id.go:408	/ipfs/id/1.0.0 sent message to QmRQ12K5JqoscDFq9EQTHuiPoDNXjcD2wcpMwYD23m885q /ip4/1.2.3.10/tcp/1237
  2022-07-01T16:37:11.202Z	DEBUG	net/identify	identify/id.go:408	/ipfs/id/1.0.0 sent message to Qmaj3Hr7dGd4MJGqPSFGvXDhvJZzyHdFFDpX3SEvyPHDdF /ip4/127.0.0.1/tcp/10086
  2022-07-01T16:37:11.202Z	DEBUG	net/identify	identify/id.go:440	/ipfs/id/1.0.0 received message from QmRQ12K5JqoscDFq9EQTHuiPoDNXjcD2wcpMwYD23m885q /ip4/1.2.3.10/tcp/1237
  2022-07-01T16:37:11.202Z	DEBUG	net/identify	identify/id.go:440	/ipfs/id/1.0.0 received message from Qmaj3Hr7dGd4MJGqPSFGvXDhvJZzyHdFFDpX3SEvyPHDdF /ip4/127.0.0.1/tcp/10086
  2022-07-01T16:37:11.202Z	DEBUG	net/identify	identify/id.go:636	Qmaj3Hr7dGd4MJGqPSFGvXDhvJZzyHdFFDpX3SEvyPHDdF received listen addrs for QmRQ12K5JqoscDFq9EQTHuiPoDNXjcD2wcpMwYD23m885q: [/ip4/1.2.3.10/tcp/1237]
  2022-07-01T16:37:11.202Z	DEBUG	net/identify	identify/id.go:636	QmRQ12K5JqoscDFq9EQTHuiPoDNXjcD2wcpMwYD23m885q received listen addrs for Qmaj3Hr7dGd4MJGqPSFGvXDhvJZzyHdFFDpX3SEvyPHDdF: [/ip4/127.0.0.1/tcp/10086]
  2022-07-01T16:37:11.202Z	DEBUG	net/identify	identify/obsaddr.go:397	added own observed listen addr	{"observed": "/ip4/1.2.3.10/tcp/1237"}
      obsaddr_test.go:228: 
          	Error Trace:	obsaddr_test.go:228
          	Error:      	Condition never satisfied
          	Test:       	TestObsAddrSet
          	Messages:   	addrs should have timed out
  --- FAIL: TestObsAddrSet (2.75s)

@marten-seemann marten-seemann mentioned this issue Jan 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarcoPolo MarcoPolo

Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

identify: refactor sending of Identify pushes libp2p/go-libp2p
3 participants
@MarcoPolo @marten-seemann @aarshkshah1992