Autorelay is announcing a bare-IP multiaddr

[Stebalien]

That is, /ip4/.../ipfs/... (no tcp/udp).

[Stebalien]

Or maybe it's autonat? No idea but this only happens after autonat decides that I'm undialable.

[vyzo]

It's autorelay and it's on purpose -- we'd like to preserve the original IP address in order to facilitate the dialer in making decisions whether to try private IPs.
We can remove if you think it's undesirable.

[vyzo]

to facilitate the v2 dialer that is, current dialer will dial the private addresses anyway.

[vyzo]

#511 removes the raw public address from the announcement.

[Stebalien]

Ah, I forgot about that. Seeing this show up in ipfs id is mildly confusing but this seems important.

What if we announce /p2p/QmRelay/ip4/PUBLIC/tcp/4001/p2p/QmTarget? Thoughts @raulk/@vyzo?

[vyzo]

Kind of defeats the purpose, the dialer will have to fish a private ip out of a relay address.
Regardless, I think we can turn it off until we actually have a dialer that takes advantage of it, at which point we can reinstate it (or decide on a better mechanism).

[Stebalien]

Kind of defeats the purpose, the dialer will have to fish a private ip out of a relay address.

Not sure what you mean here.

[vyzo]

Well, the dialer (v2) will have to use a public address from which to decide whether the private addresses are applicable. Having it flat out as an undialable address facilitates the selection.
In principle we could do the same with embedding the public ip in the relay address, it's just a bit more work for the dialer (and a bit more confusion).

[vyzo]

Also, there is no clean mapping of public addresses to relay addresses, as we might have multple public ones, each mapping to potentially multiple relay addresses -- a bit of combinatorial explosion.

[Stebalien]

Also, there is no clean mapping of public addresses to relay addresses, as we might have multple public ones, each mapping to potentially multiple relay addresses -- a bit of combinatorial explosion.

Good point. Yeah, let's merge that PR while we think about this. The best solution may be to just filter this in the UI.

[Stebalien]

@vyzo is there an open issue discussing this?

[vyzo]

No that i know, we should probably make one.