Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quicreuse: is not closed when closing the host #2117

Closed
marten-seemann opened this issue Feb 19, 2023 · 0 comments · Fixed by #2118
Closed

quicreuse: is not closed when closing the host #2117

marten-seemann opened this issue Feb 19, 2023 · 0 comments · Fixed by #2118
Labels
effort/hours Estimated to take one or several hours exp/intermediate Prior experience is likely helpful kind/maintenance Work required to avoid breaking changes or harm to project's status quo

Comments

@marten-seemann
Copy link
Contributor

The reason is that it's (if not provided by the user) created by Fx, and since we're not using the Fx application lifecycle yet, we have no way of telling when a host is shut down.
@marten-seemann marten-seemann added kind/maintenance Work required to avoid breaking changes or harm to project's status quo exp/intermediate Prior experience is likely helpful effort/hours Estimated to take one or several hours labels Feb 19, 2023
@marten-seemann marten-seemann mentioned this issue Feb 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort/hours Estimated to take one or several hours exp/intermediate Prior experience is likely helpful kind/maintenance Work required to avoid breaking changes or harm to project's status quo
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use Fx to start and stop the host, swarm, autorelay and quicreuse libp2p/go-libp2p
1 participant
@marten-seemann