From 676a35f59bfcdb0fa0e385c443a35540ea6ecf4a Mon Sep 17 00:00:00 2001 From: Jorropo Date: Wed, 16 Aug 2023 18:22:51 +0200 Subject: [PATCH] tests: add a CertHashes testcase in TestInferWebtransportAddrsFromQuic (#2495) Also do not sort the test cases twice. --- p2p/host/basic/basic_host_test.go | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/p2p/host/basic/basic_host_test.go b/p2p/host/basic/basic_host_test.go index 1093da3121..ecaaeb20d7 100644 --- a/p2p/host/basic/basic_host_test.go +++ b/p2p/host/basic/basic_host_test.go @@ -838,6 +838,11 @@ func TestInferWebtransportAddrsFromQuic(t *testing.T) { in: []string{"/ip4/0.0.0.0/udp/9999/quic-v1", "/ip4/0.0.0.0/udp/9999/quic-v1/webtransport", "/ip4/1.2.3.4/udp/9999/quic-v1"}, out: []string{"/ip4/0.0.0.0/udp/9999/quic-v1", "/ip4/0.0.0.0/udp/9999/quic-v1/webtransport", "/ip4/1.2.3.4/udp/9999/quic-v1", "/ip4/1.2.3.4/udp/9999/quic-v1/webtransport"}, }, + { + name: "Happy Path With CertHashes", + in: []string{"/ip4/0.0.0.0/udp/9999/quic-v1", "/ip4/0.0.0.0/udp/9999/quic-v1/webtransport/certhash/uEgNmb28/certhash/uEgNmb28", "/ip4/1.2.3.4/udp/9999/quic-v1"}, + out: []string{"/ip4/0.0.0.0/udp/9999/quic-v1", "/ip4/0.0.0.0/udp/9999/quic-v1/webtransport/certhash/uEgNmb28/certhash/uEgNmb28", "/ip4/1.2.3.4/udp/9999/quic-v1", "/ip4/1.2.3.4/udp/9999/quic-v1/webtransport"}, + }, { name: "Already discovered", in: []string{"/ip4/0.0.0.0/udp/9999/quic-v1", "/ip4/0.0.0.0/udp/9999/quic-v1/webtransport", "/ip4/1.2.3.4/udp/9999/quic-v1", "/ip4/1.2.3.4/udp/9999/quic-v1/webtransport"}, @@ -877,9 +882,6 @@ func TestInferWebtransportAddrsFromQuic(t *testing.T) { sort.StringSlice(tc.in).Sort() sort.StringSlice(tc.out).Sort() min := make([]ma.Multiaddr, 0, len(tc.in)) - sort.Slice(tc.in, func(i, j int) bool { - return tc.in[i] < tc.in[j] - }) for _, addr := range tc.in { min = append(min, ma.StringCast(addr)) }