From ce344a839ec5b27250becf11d4203b7d426ad569 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ra=C3=BAl=20Kripalani?= <raul@protocol.ai>
Date: Thu, 23 May 2019 18:45:35 +0100
Subject: [PATCH] SubtestPingPong: ensure connections are closed.

https://github.com/libp2p/go-libp2p-transport/pull/51
---
 suites/transport/transport_suite.go | 23 +++++++++++++++++------
 1 file changed, 17 insertions(+), 6 deletions(-)

diff --git a/suites/transport/transport_suite.go b/suites/transport/transport_suite.go
index 213cfe9..eef75bf 100644
--- a/suites/transport/transport_suite.go
+++ b/suites/transport/transport_suite.go
@@ -169,21 +169,33 @@ func SubtestPingPong(t *testing.T, ta, tb transport.Transport, maddr ma.Multiadd
 	}
 	defer list.Close()
 
+	var (
+		connA, connB transport.CapableConn
+	)
+	defer func() {
+		if connA != nil {
+			connA.Close()
+		}
+		if connB != nil {
+			connB.Close()
+		}
+	}()
+
 	var wg sync.WaitGroup
 
 	wg.Add(1)
 	go func() {
 		defer wg.Done()
-		c, err := list.Accept()
+		var err error
+		connA, err = list.Accept()
 		if err != nil {
 			t.Error(err)
 			return
 		}
-		defer c.Close()
 
 		var sWg sync.WaitGroup
 		for i := 0; i < streams; i++ {
-			s, err := c.AcceptStream()
+			s, err := connA.AcceptStream()
 			if err != nil {
 				t.Error(err)
 				return
@@ -225,14 +237,13 @@ func SubtestPingPong(t *testing.T, ta, tb transport.Transport, maddr ma.Multiadd
 		t.Error("CanDial should have returned true")
 	}
 
-	c, err := tb.Dial(ctx, list.Multiaddr(), peerA)
+	connB, err = tb.Dial(ctx, list.Multiaddr(), peerA)
 	if err != nil {
 		t.Fatal(err)
 	}
-	defer c.Close()
 
 	for i := 0; i < streams; i++ {
-		s, err := c.OpenStream()
+		s, err := connB.OpenStream()
 		if err != nil {
 			t.Error(err)
 			continue