Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace dead(not missing) peers & candidates #58

Closed
aarshkshah1992 opened this issue Mar 10, 2020 · 2 comments
Closed

Replace dead(not missing) peers & candidates #58

aarshkshah1992 opened this issue Mar 10, 2020 · 2 comments
Assignees

Comments

@aarshkshah1992
Copy link
Contributor

Based on some good ideas by @aschmahmann , here's a couple of things we can do to improve how we manage the replacement cache & "dead" peers:

  1. Since the replacement cache is bounded, we could lose potential candidates if it's full. So, when we eject a candidate from the replacement cache either because it goes into the RT or it's not reachable, we should replace it with a connected peer that is neither in the RT nor in the replacement cache.
    See RT connectivity changes go-libp2p-kad-dht#482 (comment) for the motivating discussion.

  2. When DHT calls HandleDeadPeer on the RT for a peer, we immediately eject it from the RT without replacing it. Currently, the DHT does this for a connected peer that stops being a DHT server. We should replace such peers.

@aarshkshah1992
Copy link
Contributor Author

ping @Stebalien.

@aarshkshah1992
Copy link
Contributor Author

We now have a new RT management algo at #66.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant