From 315dea5b598ff02bc17550a4704511ee4c153d6d Mon Sep 17 00:00:00 2001
From: Adrian Lanzafame <adrianlanzafame92@gmail.com>
Date: Thu, 27 Jun 2019 15:24:16 +0200
Subject: [PATCH] give views names again

---
 metrics/metrics.go | 57 +++++++++++++++++++++++++++++-----------------
 1 file changed, 36 insertions(+), 21 deletions(-)

diff --git a/metrics/metrics.go b/metrics/metrics.go
index bbe480154..23bcbf9d9 100644
--- a/metrics/metrics.go
+++ b/metrics/metrics.go
@@ -41,55 +41,70 @@ var (
 	SentBytes              = stats.Int64("libp2p.io/dht/kad/sent_bytes", "Total sent bytes per RPC", stats.UnitBytes)
 )
 
-var DefaultViews = []*view.View{
-	&view.View{
+// Views
+var (
+	ReceivedMessagesView = &view.View{
 		Measure:     ReceivedMessages,
 		TagKeys:     []tag.Key{KeyMessageType, KeyPeerID, KeyInstanceID},
 		Aggregation: view.Count(),
-	},
-	&view.View{
+	}
+	ReceivedMessageErrorsView = &view.View{
 		Measure:     ReceivedMessageErrors,
 		TagKeys:     []tag.Key{KeyMessageType, KeyPeerID, KeyInstanceID},
 		Aggregation: view.Count(),
-	},
-	&view.View{
+	}
+	ReceivedBytesView = &view.View{
 		Measure:     ReceivedBytes,
 		TagKeys:     []tag.Key{KeyMessageType, KeyPeerID, KeyInstanceID},
 		Aggregation: defaultBytesDistribution,
-	},
-	&view.View{
+	}
+	InboundRequestLatencyView = &view.View{
 		Measure:     InboundRequestLatency,
 		TagKeys:     []tag.Key{KeyMessageType, KeyPeerID, KeyInstanceID},
 		Aggregation: defaultMillisecondsDistribution,
-	},
-	&view.View{
+	}
+	OutboundRequestLatencyView = &view.View{
 		Measure:     OutboundRequestLatency,
 		TagKeys:     []tag.Key{KeyMessageType, KeyPeerID, KeyInstanceID},
 		Aggregation: defaultMillisecondsDistribution,
-	},
-	&view.View{
+	}
+	SentMessagesView = &view.View{
 		Measure:     SentMessages,
 		TagKeys:     []tag.Key{KeyMessageType, KeyPeerID, KeyInstanceID},
 		Aggregation: view.Count(),
-	},
-	&view.View{
+	}
+	SentMessageErrorsView = &view.View{
 		Measure:     SentMessageErrors,
 		TagKeys:     []tag.Key{KeyMessageType, KeyPeerID, KeyInstanceID},
 		Aggregation: view.Count(),
-	},
-	&view.View{
+	}
+	SentRequestsView = &view.View{
 		Measure:     SentRequests,
 		TagKeys:     []tag.Key{KeyMessageType, KeyPeerID, KeyInstanceID},
 		Aggregation: view.Count(),
-	},
-	&view.View{
+	}
+	SentRequestErrorsView = &view.View{
 		Measure:     SentRequestErrors,
 		TagKeys:     []tag.Key{KeyMessageType, KeyPeerID, KeyInstanceID},
 		Aggregation: view.Count(),
-	},
-	&view.View{
+	}
+	SentBytesView = &view.View{
 		Measure:     SentBytes,
 		TagKeys:     []tag.Key{KeyMessageType, KeyPeerID, KeyInstanceID},
 		Aggregation: defaultBytesDistribution,
-	},
+	}
+)
+
+// DefaultViews with all views in it.
+var DefaultViews = []*view.View{
+	ReceivedMessagesView,
+	ReceivedMessageErrorsView,
+	ReceivedBytesView,
+	InboundRequestLatencyView,
+	OutboundRequestLatencyView,
+	SentMessagesView,
+	SentMessageErrorsView,
+	SentRequestsView,
+	SentRequestErrorsView,
+	SentBytesView,
 }