Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Directly logging key strings breaks terminal emulation #680

Closed
Kubuxu opened this issue Jul 9, 2020 · 1 comment · Fixed by #682
Closed

Directly logging key strings breaks terminal emulation #680

Kubuxu opened this issue Jul 9, 2020 · 1 comment · Fixed by #682
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@Kubuxu
Copy link
Member

Kubuxu commented Jul 9, 2020

An example where it happens: https://github.com/libp2p/go-libp2p-kad-dht/blob/master/rtrefresh/rt_refresh_manager.go#L265
@Kubuxu
Copy link
Member Author

Kubuxu commented Jul 13, 2020

An actual example of this happening: filecoin-project/lotus#2392 (comment)

@Kubuxu Kubuxu added the kind/bug A bug in existing code (including security flaws) label Jul 13, 2020
@aschmahmann aschmahmann mentioned this issue Jul 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix key log encoding libp2p/go-libp2p-kad-dht
1 participant
@Kubuxu