Skip to content
This repository has been archived by the owner on Jan 3, 2022. It is now read-only.

Refactor and deprecate #18

Open
Stebalien opened this issue Mar 12, 2019 · 7 comments
Open

Refactor and deprecate #18

Stebalien opened this issue Mar 12, 2019 · 7 comments
Labels
exp/novice Someone with a little familiarity can pick up P4 Very low priority

Comments

@Stebalien
Copy link
Member

Looking at this package:

  1. It's only used from go-libp2p-swarm.
  2. Much of it's functionality belongs in either swarm or go-multiaddr-net (where it will be more discoverable).

In an effort to slim down our package list a bit, we should copy any functions we need into their respective places and then deprecate (BUT NOT REMOVE) this package.

@Stebalien
Copy link
Member Author

@anacrolix interested?

@anacrolix
Copy link

It seems like a good idea. I see https://godoc.org/github.com/libp2p/go-addr-util?importers. We could definitely archive this repo to ensure nothing more gets added.

@anacrolix anacrolix added help wanted Seeking public contribution on this issue exp/novice Someone with a little familiarity can pick up P4 Very low priority labels Mar 13, 2019
@anacrolix
Copy link

It feels like busy work, unless something in here is wrong, or may mislead users.

@Stebalien
Copy link
Member Author

No, this is super-low priority. I noticed because I was fixing a bug in this library and realized we mostly don't need it.

@Stebalien
Copy link
Member Author

(I just know you're interested in reducing our repo count).

@ghost
Copy link

ghost commented Mar 13, 2019

I can take this as part of multiformats/multiaddr#88

@ghost ghost self-assigned this Mar 13, 2019
@anacrolix anacrolix removed the help wanted Seeking public contribution on this issue label Mar 13, 2019
@raulk
Copy link
Member

raulk commented Oct 29, 2019

Agree with this change. Too much unnecessary indirection at the moment.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
exp/novice Someone with a little familiarity can pick up P4 Very low priority
Projects
None yet
Development

No branches or pull requests

3 participants