From 750d945c585c7558cd4f7e296bfebfba63ad9812 Mon Sep 17 00:00:00 2001 From: Lucas Holmquist Date: Tue, 29 Oct 2019 09:42:51 -0400 Subject: [PATCH] fs: Add noop stub for FSWatcher.prototype.start * Motivation: In a previous PR, #29905, I made this method a private method since it had no value to the user. There was discussion that maybe it should have been a runtime deprecation first, but was ultimatley decided that for this type of method, a noop stub was a better option. This Adds back in the method, but as a noop stub, while also keeping the real implementation private --- lib/internal/fs/watchers.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/internal/fs/watchers.js b/lib/internal/fs/watchers.js index 4dfa83c3b218e2..3b43c0b44d4b21 100644 --- a/lib/internal/fs/watchers.js +++ b/lib/internal/fs/watchers.js @@ -174,6 +174,8 @@ FSWatcher.prototype[kFSWatchStart] = function(filename, } }; +FSWatcher.prototype.start = () => {}; + // This method is a noop if the watcher has not been started or // has already been closed. FSWatcher.prototype.close = function() {