Skip to content

Commit

Permalink
Cherry-pick to 7.9: fix: mark flaky tests (elastic#21300) (elastic#22008
Browse files Browse the repository at this point in the history
)

* fix: mark flaky tests (elastic#21300)

* fix: mark flaky test

* Apply suggestions from code review

* Update libbeat/outputs/elasticsearch/client_integration_test.go

* Apply suggestions from code review

* Apply suggestions from code review

* Apply suggestions from code review

* fix: skip python tests too
  • Loading branch information
kuisathaverat committed Oct 20, 2020
1 parent 8e32710 commit 19dad39
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 0 deletions.
2 changes: 2 additions & 0 deletions auditbeat/module/file_integrity/eventreader_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ func init() {
const ErrorSharingViolation syscall.Errno = 32

func TestEventReader(t *testing.T) {
t.Skip("Flaky test: about 1/10 of bulds fails https://github.com/elastic/beats/issues/21302")
// Make dir to monitor.
dir, err := ioutil.TempDir("", "audit")
if err != nil {
Expand Down Expand Up @@ -240,6 +241,7 @@ func TestEventReader(t *testing.T) {
}

func TestRaces(t *testing.T) {
t.Skip("Flaky test: about 1/20 of bulds fails https://github.com/elastic/beats/issues/21303")
const (
fileMode os.FileMode = 0640
N = 100
Expand Down
2 changes: 2 additions & 0 deletions filebeat/tests/system/test_reload_inputs.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import os
import time
import unittest
from filebeat import BaseTest


Expand Down Expand Up @@ -249,6 +250,7 @@ def test_load_configs(self):
assert output[0]["message"] == first_line
assert output[1]["message"] == second_line

@unittest.skip("1/20 build fails https://github.com/elastic/beats/issues/21307")
def test_reload_same_config(self):
"""
Test reload same config with same file but different config. Makes sure reloading also works on conflicts.
Expand Down
1 change: 1 addition & 0 deletions x-pack/auditbeat/tests/system/test_metricsets.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ def test_metricset_login(self):
# Metricset is beta and that generates a warning, TODO: remove later
self.check_metricset("system", "login", COMMON_FIELDS + fields, config, warnings_allowed=True)

@unittest.skip("1/20 build fails https://github.com/elastic/beats/issues/21308")
@unittest.skipIf(sys.platform == "win32", "Not implemented for Windows")
@unittest.skipIf(sys.platform.startswith('linux') and not (os.path.isdir("/var/lib/dpkg") or os.path.isdir("/var/lib/rpm")),
"Only implemented for dpkg and rpm")
Expand Down

0 comments on commit 19dad39

Please sign in to comment.