diff --git a/.gitignore b/.gitignore index dce57c236ee..b5a5bf9cf2e 100644 --- a/.gitignore +++ b/.gitignore @@ -39,3 +39,7 @@ examples/.ipynb_checkpoints/ !testing/test-infra/vendor + +# This is required for testing but we don't +# want to check it in right now. +components/gcp-click-to-deploy/src/user_config/** diff --git a/kubeflow/core/tests/tf-job_test.jsonnet b/kubeflow/core/tests/tf-job_test.jsonnet index 0295c9e2012..3ab2add1265 100644 --- a/kubeflow/core/tests/tf-job_test.jsonnet +++ b/kubeflow/core/tests/tf-job_test.jsonnet @@ -521,3 +521,31 @@ std.assertEqual( ], } ) + +&& + +std.assertEqual( + tfjobv1alpha1.tfUiRoleBinding, + { + apiVersion: "rbac.authorization.k8s.io/v1beta1", + kind: "ClusterRoleBinding", + metadata: { + labels: { + app: "tf-job-dashboard", + }, + name: "tf-job-dashboard", + }, + roleRef: { + apiGroup: "rbac.authorization.k8s.io", + kind: "ClusterRole", + name: "tf-job-dashboard", + }, + subjects: [ + { + kind: "ServiceAccount", + name: "tf-job-dashboard", + namespace: "test-kf-001", + }, + ], + } +) diff --git a/kubeflow/core/tf-job-operator.libsonnet b/kubeflow/core/tf-job-operator.libsonnet index 505638b7207..04745ee3aa3 100644 --- a/kubeflow/core/tf-job-operator.libsonnet +++ b/kubeflow/core/tf-job-operator.libsonnet @@ -486,9 +486,9 @@ }, subjects: [ { - kind: tfServiceAccount.kind, - name: tfServiceAccount.metadata.name, - namespace: tfServiceAccount.metadata.namespace, + kind: tfUiServiceAccount.kind, + name: tfUiServiceAccount.metadata.name, + namespace: tfUiServiceAccount.metadata.namespace, }, ], },