Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Helpers in a package #8

Closed
HollyFredD opened this issue Jul 14, 2022 · 2 comments
Closed

[Improvement] Helpers in a package #8

HollyFredD opened this issue Jul 14, 2022 · 2 comments

Comments

@HollyFredD
Copy link

Hi !
Great job here, thanks for the time spent to create and (well) document your blueprint !

In the wiki, I would suggest to make things a bit cleaner (ie. not overloading the configuration.yaml file) suggesting to create packages.

In the configuration.yaml file :

## Packages
homeassistant:
  packages: !include_dir_named packages/

And then add the "devices" in the folder /packages
For example washing_machine.yaml based on the template you provided :

timer:
  washing_machine_delayed_job_completion_timer:
    name: Washing Machine - Delayed Job Completion Timer
    duration: "00:15:00" # <- Note that the time here. Leave as it is (15 min)
    restore: true
    icon: mdi:washing-machine

  # ...

input_boolean:
  washing_machine_job_cycle:
    name: Washing Machine - Job Cycle
    icon: mdi:washing-machine

  washing_machine_automation_self_trigger:
    name: Washing Machine - Automation Self-trigger
    icon: mdi:washing-machine

  # ...

input_select:
  washing_machine_state_machine:
    name: Washing Machine - State Machine
    options:
      - unplugged
      - idle
      - paused
      - detached_overload
      - job_ongoing
      - job_completed
    icon: mdi:washing-machine

This will help keep the HA configuration simpler and more maintainable in my humble opinion

@leofabri
Copy link
Owner

Hi @HollyFredD! Thank you for your nice suggestion!

I love this solution! It makes everything way cleaner and well organized.
I will change the wiki to reflect these tips with the release of the next version of the blueprint (we are not far from it).

@leofabri
Copy link
Owner

Done! The new branch has been added and it now includes the suggested change. It has not been merged yet. I need to improve some other things and push some more updates to the docs.

It'll turn into the new main when the job is completed.

Thank you again, have a great day ahead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants