From c6bb3f78dbc987dad32b721d999a32d04229875f Mon Sep 17 00:00:00 2001 From: Ryan Lamb <4955475+kinyoklion@users.noreply.github.com> Date: Thu, 23 May 2024 14:27:31 -0700 Subject: [PATCH 1/4] chore: Run contract tests on windows. --- .github/workflows/sdk-server-ci.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/.github/workflows/sdk-server-ci.yml b/.github/workflows/sdk-server-ci.yml index 048887f6..7516783d 100644 --- a/.github/workflows/sdk-server-ci.yml +++ b/.github/workflows/sdk-server-ci.yml @@ -23,10 +23,7 @@ jobs: project_file: pkgs/sdk/server/src/LaunchDarkly.ServerSdk.csproj test_project_file: pkgs/sdk/server/test/LaunchDarkly.ServerSdk.Tests.csproj - # Running contract tests on windows is currently cumbersome. - # Once that has been addressed, then running contract tests on windows should be considered. - uses: ./.github/actions/contract-tests - if: ${{ matrix.os != 'windows-latest' }} with: service_project_file: pkgs/sdk/server/contract-tests/TestService.csproj service_dll_file: pkgs/sdk/server/contract-tests/bin/debug/net6.0/ContractTestService.dll From 88f756381445fd061281fda77a999a4b40ceb868 Mon Sep 17 00:00:00 2001 From: Ryan Lamb <4955475+kinyoklion@users.noreply.github.com> Date: Thu, 23 May 2024 15:49:03 -0700 Subject: [PATCH 2/4] Extra slash for parameter. --- .github/actions/contract-tests/action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/actions/contract-tests/action.yml b/.github/actions/contract-tests/action.yml index 5205065a..a89b81ef 100644 --- a/.github/actions/contract-tests/action.yml +++ b/.github/actions/contract-tests/action.yml @@ -22,7 +22,7 @@ runs: - name: Build Contract Tests shell: bash - run: dotnet build /p:Configuration=debug ${{ inputs.service_project_file }} + run: dotnet build //p:Configuration=Debug ${{ inputs.service_project_file }} - name: Launch Contract Tests id: launch-contract-tests From cdba822aa72c88b4b111ef4561e3b652248eaec6 Mon Sep 17 00:00:00 2001 From: Ryan Lamb <4955475+kinyoklion@users.noreply.github.com> Date: Thu, 23 May 2024 15:51:18 -0700 Subject: [PATCH 3/4] Dash instead. --- .github/actions/contract-tests/action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/actions/contract-tests/action.yml b/.github/actions/contract-tests/action.yml index a89b81ef..444b1d43 100644 --- a/.github/actions/contract-tests/action.yml +++ b/.github/actions/contract-tests/action.yml @@ -22,7 +22,7 @@ runs: - name: Build Contract Tests shell: bash - run: dotnet build //p:Configuration=Debug ${{ inputs.service_project_file }} + run: dotnet build -p:Configuration=Debug ${{ inputs.service_project_file }} - name: Launch Contract Tests id: launch-contract-tests From 59e9dac3cce65c619dc986257a02d081cd18f90f Mon Sep 17 00:00:00 2001 From: Ryan Lamb <4955475+kinyoklion@users.noreply.github.com> Date: Thu, 23 May 2024 15:58:51 -0700 Subject: [PATCH 4/4] Lowercase debug. --- .github/actions/contract-tests/action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/actions/contract-tests/action.yml b/.github/actions/contract-tests/action.yml index 444b1d43..19762152 100644 --- a/.github/actions/contract-tests/action.yml +++ b/.github/actions/contract-tests/action.yml @@ -22,7 +22,7 @@ runs: - name: Build Contract Tests shell: bash - run: dotnet build -p:Configuration=Debug ${{ inputs.service_project_file }} + run: dotnet build -p:Configuration=debug ${{ inputs.service_project_file }} - name: Launch Contract Tests id: launch-contract-tests