Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlx_core::Transaction not re-exported in sqlx #113

Closed
stadust opened this issue Feb 24, 2020 · 3 comments
Closed

sqlx_core::Transaction not re-exported in sqlx #113

stadust opened this issue Feb 24, 2020 · 3 comments

Comments

@stadust
Copy link

stadust commented Feb 24, 2020

Hi )/

Currently sqlx_core::Transaction isn't re-exported in sqlx. This means I cannot write out the return type of a function returning a connection acquired with ConnectionPool::begin

Since the struct is public in sqlx_core I could work around it by adding sqlx_core to my Cargo.toml but it'd be nice to have it re-exported directly in sqlx.

@jsdw
Copy link

jsdw commented Feb 24, 2020

I came to say the same thing (and wow, only 8 minutes apart!) - it would be nice to have this type exported from sqlx :)

@stadust
Copy link
Author

stadust commented Feb 27, 2020

I could submit a PR for this if that's wanted? I'm afraid I'm not really familiar with github etiquette :(

@mehcode
Copy link
Member

mehcode commented Feb 27, 2020

Definitely wanted but @thedodd beat you to the PR: #114

Re: etiquette, personally I would have just made a PR for something small like this. Making an issue first (or asking on Discord) is more to save you from unneeded work. Either way, anyone ( including us ) are happy for your contribution in any form ( even just opening an issue saying "hey you missed this" ).

@mehcode mehcode closed this as completed Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants