Failed job not showing

[shadoWalker89]

Hi,

So i have a failed job that is not showing on the horizon failed jobs tab. But it is showing in the dashboard

But the list of failed jobs is empty

Even though the ajax request shows the total as 1 but the jobs array is empty

And this is also a screenshot of the database

If i go to the recent jobs tab i see the failed job

And when i click on it it opens the failed job details page at this uri ".../failed/11"

I'm using

php 7.2.15
laravel 5.7.28
horizon 3.0.0

[driesvints]

Hmm. I've been looking into this but can't seem to reproduce it. Can you perhaps post some code and/or set up a test app?

[shadoWalker89]

I'm not doing anything fancy.

Just using the ShouldQueue interface on a mail class.

The error that you are seeing is caused by me making a syntax error in the email markdown file to test the failed jobs tab.

I'm not familiar with horizon code, and this is my first time using horizon but i suspect that this has something to do with redis and this is why.

The redis command being executed to get the failed jobs is zrange failed_jobs 1 50
The redis command being executed to get the failed jobs count is zcount failed_jobs -inf -1550754504

In my redis-cli if i do zrangebyscore horizon:failed_jobs 1 50 i get (empty list or set)
If i do zrangebyscore horizon:failed_jobs -inf 50 i get (empty list or set) i get

1) "11"

I think the problem is when trying to get the failed jobs but with 1 instead of -inf

If you follow this call

horizon/src/Http/Controllers/FailedJobsController.php

Line 49 in c32b172

? $this->paginate($request)

down to

horizon/src/Repositories/RedisJobRepository.php

Line 160 in c32b172

$type, $afterIndex + 1, $afterIndex + 50

You will see that in the ajax request the query string starting_at=0, to the $afterIndex + 1 will give 1 that is reflected in the redis command to get failed jobs ids zrange failed_jobs 1 50

[driesvints]

Can you try to replace line 160 with the following and see what happens?

$type, $afterIndex ? $afterIndex + 1 : '-inf', $afterIndex + 50

[shadoWalker89]

That will give an error Redis::zRange() expects parameter 2 to be integer, string given
But replacing the -inf with -1 does the trick and the failed job is displayed.

But if you check this line

horizon/src/Repositories/RedisJobRepository.php

Line 157 in c32b172

$afterIndex = $afterIndex === null ? -1 : $afterIndex;

You will see that similar check is there with the exception that is checking for === null

I think that maybe the line below is the one that should change

horizon/src/Http/Controllers/FailedJobsController.php

Line 70 in c32b172

return $this->jobs->getFailed($request->query('starting_at', -1))->map(function ($job) {

if the starting_at is 0 then pass null

Also should change the default value to null if the parameter starting_at does not exist.
Because back to the line 160 if -1 is passed the will have -1 + 1 which gives 0 and then the command will be

zrange failed_jobs 0 50

Which does not work and return an empty set

I think maybe this is the proper change (it works for me)

// Failed jobs controller
    protected function paginate(Request $request)
    {
        $starting_at = $request->query('starting_at', null);

        return $this->jobs->getFailed($starting_at === '0' ? null : $starting_at)->map(function ($job) {
            return $this->decode($job);
        });
    }

Note: I don't know but maybe you should also the paginateByTag() method on the controller

[driesvints]

Can you try this?

return $this->jobs->getFailed($request->query('starting_at') ?: -1)->map(function ($job) {
    return $this->decode($job);
});

[shadoWalker89]

Yeah that works as well

[driesvints]

Cool. I think the paginateByTag method is ok because the implementation is slightly different there. Actually I believe that's the solution all along. Can you try one more time with this change:

return $this->jobs->getFailed($request->query('starting_at', -1) + 1)->map(function ($job) {
    return $this->decode($job);
});

[shadoWalker89]

Not this last one does not work.
Go back to having an empty array for the jobs

[driesvints]

Ah I see, that's because it's a different method call. I'll send in a PR with the fix. Thanks for reporting.