Collection tap changes wrong collection

[Fuzzyma]

The tap method of Collection seems broken. I only read the source but to me it seems like the callack gets passed a copy of the collection but NOT the copy is returned. So basically the callback acts on a Collection which will be GarbageCollected afterwards:

    public function tap(callable $callback)
    {
        $callback(new static($this->items));
        return $this;
    }

Source

[staudenmeir]

The original PR explains it: #17756

[JosephSilber]

@staudenmeir and the original PR is wrong 😢

[Fuzzyma]

I KNEW it!!! :D