save() and create() not working as expected

[asanikovich]

• Laravel Version: 5.3.26
• PHP Version: 5.6.12
• Database Driver & Version: MySQL 5.6.26

Description:

'exists' property on model wrong indicates if the model exists.
We need to know if a model really created.
You can check example: asanikovich/laravel@c3ad907
🔢 Config db, migrate and run 'php artisan test'

Steps To Reproduce:

Example migration for model buyer_users (user - default model):

        Schema::create('buyer_users', function (Blueprint $table) {
            $table->unsignedInteger('user_id')->primary();
            $table->text('favorite_json')->nullable();
        });

Model should be with:

    protected $primaryKey = 'user_id';
    public $incrementing = false;

And if we try to create a model through save():

            $buyer = new BuyerUser;
            $result = $buyer->save();
            var_dump($buyer->exists, $result); // both values will be 'true'

or create():

            $buyer = BuyerUser::create();
            var_dump($buyer->exists, !!$buyer); // both values will be 'true'

But the real row does not exists in DB.

[sagarrabadiya]

i think if you don't have given default values to your db table columns it will throw SQLSTATE exception and if you have assigned default values to your db table columns row will be created with that default value.

[asanikovich]

@sagarrabadiya
You can see thay I have:
$table->unsignedInteger('user_id')->primary();
It has not default value.

[sagarrabadiya]

in that case it should throw SQLSTATE exception, are you getting that exception thrown?

[asanikovich]

@sagarrabadiya No. I don't have exception.

[asanikovich]

@sagarrabadiya
You can check example: asanikovich/laravel@c3ad907
🔢 Config db, migrate and run 'php artisan test'

[themsaid]

Unable to reproduce, please provide a simple example I can use on a fresh laravel 5.3 installation.

[themsaid]

ping @allok

[asanikovich]

Look example in my repository https://github.com/allok/laravel

[themsaid]

Submitted a PR with a fix #16864

Thank you so much :)