Storage::delete does not return accurate result

[thunberg]

Storage::delete with the local driver always returns true:

    public function delete($paths)
    {
        $paths = is_array($paths) ? $paths : func_get_args();

        foreach ($paths as $path) {
            try {
                $this->driver->delete($path);
            } catch (FileNotFoundException $e) {
                //
            }
        }

        return true;
    }

This is not helpful when attempting to first confirm an object's associated file upload was successfully deleted before deleting the object itself.

Since the local filesystem driver already returns the correct result:

    public function delete($path)
    {
        $location = $this->applyPathPrefix($path);

        return unlink($location);
    }

Why can't we change the delete function in FilesystemAdapter to:

    public function delete($paths)
    {
        $paths = is_array($paths) ? $paths : func_get_args();

        $success = true;

        foreach ($paths as $path) {
            try {
                $success = $this->driver->delete($path);
            } catch (FileNotFoundException $e) {
                $success = false;
            }
        }

        return $success;
    }

I'm relatively new to Laravel, so apologies if I've missed a more appropriate way to handle this -- thank you either way.

[srmklive]

I would suggest that you do it like this:

if ($this->driver->has($path)) {
    $this->driver->delete($path);
}

[thunberg]

Thank you for the reply, but that doesn't handle the case when a delete fails.

[thunberg]

Thank you for the fix.