diff --git a/.github/workflows/ci-workflow.yml b/.github/workflows/ci-workflow.yml index 8fc91b162e..ff5112859d 100644 --- a/.github/workflows/ci-workflow.yml +++ b/.github/workflows/ci-workflow.yml @@ -269,30 +269,6 @@ jobs: call "C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Auxiliary\Build\vcvars64.bat" make javatest - tidy-and-diagnostics: - name: clang tidy & clangd diagnostics check - needs: [clang-format, sanity-checks] - runs-on: kuzu-self-hosted-testing - env: - NUM_THREADS: 32 - - steps: - - uses: actions/checkout@v3 - - # For `napi.h` header. - - name: Ensure Node.js dependencies - run: npm install --include=dev - working-directory: tools/nodejs_api - - - name: Check for clangd diagnostics - run: make clangd-diagnostics - - - name: Run clang-tidy - run: make tidy - - - name: Run clang-tidy analyzer - run: make tidy-analyzer - sanity-checks: name: sanity checks runs-on: ubuntu-22.04 @@ -382,17 +358,19 @@ jobs: needs: [gcc-build-test, clang-build-test] uses: ./.github/workflows/benchmark-workflow.yml - macos-clang-tidy: - name: macos clang tidy & clangd diagnostics check + clang-tidy: + name: clang tidy & clangd diagnostics check needs: [clang-format, sanity-checks] - runs-on: self-hosted-mac-x64 + runs-on: kuzu-self-hosted-testing env: - NUM_THREADS: 32 GEN: ninja + NUM_THREADS: 32 + CC: clang + CXX: clang++ steps: - uses: actions/checkout@v3 - + # For `napi.h` header. - name: Ensure Node.js dependencies run: npm install --include=dev diff --git a/src/common/arrow/arrow_row_batch.cpp b/src/common/arrow/arrow_row_batch.cpp index df11bc33fb..5e8208e171 100644 --- a/src/common/arrow/arrow_row_batch.cpp +++ b/src/common/arrow/arrow_row_batch.cpp @@ -359,7 +359,6 @@ void ArrowRowBatch::templateCopyNonNullValue(ArrowVector* v std::int64_t propertyId = 2; auto numProperties = NodeVal::getNumProperties(value); for (auto i = 0u; i < numProperties; i++) { - auto name = NodeVal::getPropertyName(value, i); auto val = NodeVal::getPropertyVal(value, i); appendValue(vector->childData[propertyId].get(), *StructType::getFieldTypes(&type)[propertyId], val); @@ -377,7 +376,6 @@ void ArrowRowBatch::templateCopyNonNullValue(ArrowVector* ve std::int64_t propertyId = 2; auto numProperties = NodeVal::getNumProperties(value); for (auto i = 0u; i < numProperties; i++) { - auto name = NodeVal::getPropertyName(value, i); auto val = NodeVal::getPropertyVal(value, i); appendValue(vector->childData[propertyId].get(), *StructType::getFieldTypes(&type)[propertyId], val); diff --git a/src/include/function/string/functions/contains_function.h b/src/include/function/string/functions/contains_function.h index bf90ab7269..619f676d2d 100644 --- a/src/include/function/string/functions/contains_function.h +++ b/src/include/function/string/functions/contains_function.h @@ -9,8 +9,6 @@ namespace function { struct Contains { static inline void operation(common::ku_string_t& left, common::ku_string_t& right, uint8_t& result) { - auto lStr = left.getAsString(); - auto rStr = right.getAsString(); int64_t pos; Find::operation(left, right, pos); result = (pos != 0); diff --git a/src/parser/transform/transform_expression.cpp b/src/parser/transform/transform_expression.cpp index e142a4cda0..9fc6010d0b 100644 --- a/src/parser/transform/transform_expression.cpp +++ b/src/parser/transform/transform_expression.cpp @@ -350,7 +350,6 @@ std::unique_ptr Transformer::transformNullOperatorExpression( std::unique_ptr Transformer::transformPropertyOrLabelsExpression( CypherParser::OC_PropertyOrLabelsExpressionContext& ctx) { auto atom = transformAtom(*ctx.oC_Atom()); - auto raw = ctx.oC_Atom()->getText(); if (!ctx.oC_PropertyLookup().empty()) { auto lookUpCtx = ctx.oC_PropertyLookup(0); auto result = createPropertyExpression(*lookUpCtx, std::move(atom)); diff --git a/src/planner/plan/plan_port_db.cpp b/src/planner/plan/plan_port_db.cpp index 1ab223fb39..40908fafc3 100644 --- a/src/planner/plan/plan_port_db.cpp +++ b/src/planner/plan/plan_port_db.cpp @@ -44,7 +44,6 @@ std::unique_ptr Planner::planExportDatabase(const BoundStatement& s std::unique_ptr Planner::planImportDatabase(const BoundStatement& statement) { auto& boundImportDatabase = ku_dynamic_cast(statement); - auto filePath = boundImportDatabase.getFilePath(); auto query = boundImportDatabase.getQuery(); auto plan = std::make_unique(); auto importDatabase = make_shared(query); diff --git a/src/processor/operator/hash_join/join_hash_table.cpp b/src/processor/operator/hash_join/join_hash_table.cpp index 8da39523f1..1531041fa8 100644 --- a/src/processor/operator/hash_join/join_hash_table.cpp +++ b/src/processor/operator/hash_join/join_hash_table.cpp @@ -117,7 +117,8 @@ void JoinHashTable::buildHashSlots() { for (auto i = 0u; i < tupleBlock->numTuples; i++) { auto lastSlotEntryInHT = insertEntry(tuple); auto prevPtr = getPrevTuple(tuple); - memcpy(prevPtr, &lastSlotEntryInHT, sizeof(uint8_t*)); + memcpy(reinterpret_cast(prevPtr), reinterpret_cast(&lastSlotEntryInHT), + sizeof(uint8_t*)); tuple += factorizedTable->getTableSchema()->getNumBytesPerTuple(); } }