From c45cc9aac315a21eb1ff18575fcc65ddf6dab899 Mon Sep 17 00:00:00 2001 From: Royi Luo Date: Tue, 25 Jun 2024 09:16:51 -0400 Subject: [PATCH] CI fixes --- src/storage/compression/compression.cpp | 14 +++++++------- test/storage/compression_test.cpp | 2 +- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/storage/compression/compression.cpp b/src/storage/compression/compression.cpp index d24237f9fa3..8b3637e0c4b 100644 --- a/src/storage/compression/compression.cpp +++ b/src/storage/compression/compression.cpp @@ -462,13 +462,13 @@ void IntegerBitpacking::setValuesFromUncompressed(const uint8_t* srcBuffer, o // non-zero offset However we don't care about the value stored for null values // Currently they will be mangled by storage+recovery (underflow in the subtraction // below) - KU_ASSERT( - numValues == std::ranges::count_if(std::ranges::iota_view{posInSrc, posInSrc + numValues}, - [srcBuffer, &metadata, nullMask](offset_t i) { - auto value = reinterpret_cast(srcBuffer)[i]; - return (nullMask && nullMask->isNull(i)) || - canUpdateInPlace(std::span(&value, 1), metadata); - })); + KU_ASSERT(numValues == static_cast(std::ranges::count_if( + std::ranges::iota_view{posInSrc, posInSrc + numValues}, + [srcBuffer, &metadata, nullMask](offset_t i) { + auto value = reinterpret_cast(srcBuffer)[i]; + return (nullMask && nullMask->isNull(i)) || + canUpdateInPlace(std::span(&value, 1), metadata); + }))); // Data can be considered to be stored in aligned chunks of 32 values // with a size of 32 * bitWidth bits, diff --git a/test/storage/compression_test.cpp b/test/storage/compression_test.cpp index c8eda3f67b4..22424a4a34e 100644 --- a/test/storage/compression_test.cpp +++ b/test/storage/compression_test.cpp @@ -154,7 +154,7 @@ TEST(CompressionTests, IntegerPackingTest64SetValuesFromUncompressed) { TEST(CompressionTests, IntegerPackingTest128WorksOnNonZeroBuffer) { std::vector src(128); for (size_t i = 0; i < src.size(); ++i) { - src[i] = (int128_t(1) << 125) + int128_t(i); + src[i] = (int128_t(1) << 125) + int128_t{i}; } auto alg = IntegerBitpacking(); std::vector dest(sizeof(int128_t) * src.size(), 0xff);