From 5e841780ff7935fd0c00e024aab113474e8964ce Mon Sep 17 00:00:00 2001 From: Michael O Toole Date: Wed, 17 Apr 2024 23:03:37 +0200 Subject: [PATCH] CALL to be readonly=true (#3302) * CALL to be readonly=true * Remove Test for readonly --- src/include/parser/visitor/statement_read_write_analyzer.h | 2 +- test/test_files/tinysnb/call/call.test | 7 ------- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/src/include/parser/visitor/statement_read_write_analyzer.h b/src/include/parser/visitor/statement_read_write_analyzer.h index 268e9aa98d..612180c3d8 100644 --- a/src/include/parser/visitor/statement_read_write_analyzer.h +++ b/src/include/parser/visitor/statement_read_write_analyzer.h @@ -16,7 +16,7 @@ class StatementReadWriteAnalyzer final : public StatementVisitor { inline void visitDropTable(const Statement& /*statement*/) override { readOnly = false; } inline void visitAlter(const Statement& /*statement*/) override { readOnly = false; } inline void visitCopyFrom(const Statement& /*statement*/) override { readOnly = false; } - inline void visitStandaloneCall(const Statement& /*statement*/) override { readOnly = false; } + inline void visitStandaloneCall(const Statement& /*statement*/) override { readOnly = true; } inline void visitCreateMacro(const Statement& /*statement*/) override { readOnly = false; } inline void visitCommentOn(const Statement& /*statement*/) override { readOnly = false; } diff --git a/test/test_files/tinysnb/call/call.test b/test/test_files/tinysnb/call/call.test index 4c59449abd..ff2daf13e1 100644 --- a/test/test_files/tinysnb/call/call.test +++ b/test/test_files/tinysnb/call/call.test @@ -78,13 +78,6 @@ True ---- 1 False --LOG CallTransaction --STATEMENT BEGIN TRANSACTION READ ONLY; ----- ok --STATEMENT CALL var_length_extend_max_depth=10 ----- error -Can not execute a write query inside a read-only transaction. - -LOG NodeTableInfo -STATEMENT CALL table_info('person') RETURN * ---- 16