Add GroupedEnumFilter #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScreenshotsExample usage on Provider list screen.
|
The new filter supports displaying enum values divided into groups. The groups are only for presentation and better user experience - logically the values belong to the same enum. Technically the approach (using nested ToolbarFilter) is borrowed from the Console filter-toolbar [1]. [1] https://github.com/openshift/console/blob/5ba18580676a25e4304df78253aad6a9832d4d56/frontend/public/components/filter-toolbar.tsx#L299 Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
rszwajko
force-pushed
the
srcProvider
branch
from
aed32c8
to
bd1471d
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
yaacov
approved these changes
Nov 23, 2022
sjd78
pushed a commit
to konveyor/tackle2-ui
that referenced
this pull request
May 23, 2024
Use one ToolbarFilter per options group. First filter provides the option list. Remaining filters are hidden and used only for side effects (separate chip groups). The approach follows similar widgets used by Forklift plugin and OpenShift Console but uses a flat list of toolbars (nesting trick requires the widget to be visible all the time). Related refactorings in MuliselectFilterControl: 1. drop unused feature - using dictionary type for selectedOptions 2. drop state that can be calculated: a) active item from focusedItemIndex b) selectedOptions from filters 3. centralize id calculations - use prefix based on category title 4. use label styling for tag category part of option Resolves: #1774 Reference-Url: kubev2v/forklift-console-plugin#90 Reference-Url: https://github.com/openshift/console/blob/5ba18580676a25e4304df78253aad6a9832d4d56/frontend/public/components/filter-toolbar.tsx#L299 --------- Signed-off-by: Radoslaw Szwajkowski <rszwajko@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new filter supports displaying enum values divided into groups. The groups are only for presentation and better user experience - logically the values belong to the same enum.
Technically the approach (using nested ToolbarFilter) is borrowed from the Console filter-toolbar [1].
[1] https://github.com/openshift/console/blob/5ba18580676a25e4304df78253aad6a9832d4d56/frontend/public/components/filter-toolbar.tsx#L299
Signed-off-by: Radoslaw Szwajkowski rszwajko@redhat.com