From 23902058f9e0ddfb867e4223d85fbd01dde60695 Mon Sep 17 00:00:00 2001 From: Vincent Van Driessche Date: Fri, 29 Mar 2019 17:05:11 +0100 Subject: [PATCH] Adds a log warning when falling back to default fake cert --- internal/ingress/controller/controller.go | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/internal/ingress/controller/controller.go b/internal/ingress/controller/controller.go index b596fcb449..5a63fd3352 100644 --- a/internal/ingress/controller/controller.go +++ b/internal/ingress/controller/controller.go @@ -866,10 +866,14 @@ func (n *NGINXController) createServers(data []*ingress.Ingress, defaultPemSHA := n.cfg.FakeCertificateSHA // read custom default SSL certificate, fall back to generated default certificate - defaultCertificate, err := n.store.GetLocalSSLCert(n.cfg.DefaultSSLCertificate) - if err == nil { - defaultPemFileName = defaultCertificate.PemFileName - defaultPemSHA = defaultCertificate.PemSHA + if n.cfg.DefaultSSLCertificate != "" { + defaultCertificate, err := n.store.GetLocalSSLCert(n.cfg.DefaultSSLCertificate) + if err == nil { + defaultPemFileName = defaultCertificate.PemFileName + defaultPemSHA = defaultCertificate.PemSHA + } else { + klog.Warningf("Error loading custom default certificate, falling back to generated default:\n%v", err) + } } // initialize default server and root location