From a7e856ea06cba9d61375ce29864ff0869dbd97e9 Mon Sep 17 00:00:00 2001 From: Andrew Keesler Date: Mon, 19 Jul 2021 09:50:37 -0400 Subject: [PATCH 1/4] exec credential provider: KEP updates for GA RC Signed-off-by: Andrew Keesler --- .../README.md | 22 ++++++++++--------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/keps/sig-auth/541-external-credential-providers/README.md b/keps/sig-auth/541-external-credential-providers/README.md index 3b657f24b64..f7153d388ad 100644 --- a/keps/sig-auth/541-external-credential-providers/README.md +++ b/keps/sig-auth/541-external-credential-providers/README.md @@ -36,14 +36,14 @@ ## Release Signoff Checklist -- [ ] Enhancement issue in release milestone, which links to KEP dir in [kubernetes/enhancements] (not the initial KEP PR) +- [X] Enhancement issue in release milestone, which links to KEP dir in [kubernetes/enhancements] (not the initial KEP PR) - [x] KEP approvers have approved the KEP status as `implementable` -- [ ] Design details are appropriately documented -- [ ] Test plan is in place, giving consideration to SIG Architecture and SIG Testing input -- [ ] Graduation criteria is in place -- [ ] "Implementation History" section is up-to-date for milestone -- [ ] User-facing documentation has been created in [kubernetes/website], for publication to [kubernetes.io] -- [ ] Supporting documentation e.g., additional design documents, links to mailing list discussions/SIG meetings, relevant PRs/issues, release notes +- [X] Design details are appropriately documented +- [X] Test plan is in place, giving consideration to SIG Architecture and SIG Testing input +- [X] Graduation criteria is in place +- [X] "Implementation History" section is up-to-date for milestone +- [X] User-facing documentation has been created in [kubernetes/website], for publication to [kubernetes.io] +- [X] Supporting documentation e.g., additional design documents, links to mailing list discussions/SIG meetings, relevant PRs/issues, release notes [kubernetes.io]: https://kubernetes.io/ [kubernetes/enhancements]: https://git.k8s.io/enhancements @@ -129,7 +129,7 @@ users: user: exec: # API version to use when decoding the ExecCredentials resource. Required. - apiVersion: "client.authentication.k8s.io/v1beta1" + apiVersion: "client.authentication.k8s.io/v1" # Command to execute. Required. command: "example-client-go-exec-plugin" @@ -290,7 +290,7 @@ In JSON: ```json { - "apiVersion": "client.authentication.k8s.io/v1beta1", + "apiVersion": "client.authentication.k8s.io/v1", "kind": "ExecCredential", "spec": { "interactive": true, @@ -502,7 +502,7 @@ In JSON: ```json { - "apiVersion": "client.authentication.k8s.io/v1beta1", + "apiVersion": "client.authentication.k8s.io/v1", "kind": "ExecCredential", "status": { "expirationTimestamp": "$EXPIRATION", @@ -910,3 +910,5 @@ _This section must be completed when targeting beta graduation to a release._ - 2018-01-29: Proposal submitted https://github.com/kubernetes/community/pull/1503 - 2018-02-28: Alpha (v1.10) implemented https://github.com/kubernetes/kubernetes/pull/59495 - 2018-06-04: Promoted to Beta (v1.11) https://github.com/kubernetes/kubernetes/pull/64482 +- 2021-05-11: Stable API approved https://github.com/kubernetes/enhancements/pull/2587 +- 2021-07-06: Promoted to Stable (v1.22) https://github.com/kubernetes/kubernetes/pull/102890 From a83d7fc9737ae6d4424534eb7cb122e5ff2534d7 Mon Sep 17 00:00:00 2001 From: Andrew Keesler Date: Thu, 22 Jul 2021 10:03:53 -0400 Subject: [PATCH 2/4] SQUASH: update example to match website docs Signed-off-by: Andrew Keesler --- keps/sig-auth/541-external-credential-providers/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/keps/sig-auth/541-external-credential-providers/README.md b/keps/sig-auth/541-external-credential-providers/README.md index f7153d388ad..80afcc5a763 100644 --- a/keps/sig-auth/541-external-credential-providers/README.md +++ b/keps/sig-auth/541-external-credential-providers/README.md @@ -170,7 +170,7 @@ users: # # In v1alpha1 and v1beta1, this is optional and defaults to IfAvailable. It is # required otherwise. - interactiveMode: IfAvailable + interactiveMode: Never clusters: - name: my-cluster cluster: From e2d3cf878dfdc7234d5b64a0c1d4c255a739c4e8 Mon Sep 17 00:00:00 2001 From: Andrew Keesler Date: Thu, 22 Jul 2021 10:06:15 -0400 Subject: [PATCH 3/4] SQUASH: update kep.yaml for GA Signed-off-by: Andrew Keesler --- .../541-external-credential-providers/kep.yaml | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/keps/sig-auth/541-external-credential-providers/kep.yaml b/keps/sig-auth/541-external-credential-providers/kep.yaml index 152fd2391b0..4a2b0eb5258 100644 --- a/keps/sig-auth/541-external-credential-providers/kep.yaml +++ b/keps/sig-auth/541-external-credential-providers/kep.yaml @@ -7,7 +7,7 @@ owning-sig: sig-auth participating-sigs: - sig-cli - sig-api-machinery -status: implementable +status: implemented creation-date: 2019-07-11 reviewers: - "@liggitt" @@ -17,9 +17,13 @@ approvers: - "@mikedanese" prr-approvers: - "@deads2k" -stage: beta -latest-milestone: "v1.21" +stage: stable +latest-milestone: "v1.22" milestone: alpha: "v1.10" beta: "v1.11" stable: "v1.22" +metrics: + - rest_client_exec_plugin_ttl_seconds + - rest_client_exec_plugin_certificate_rotation_age + - rest_client_exec_plugin_call_total From 446b2e44da32a64e1731a4e48df0e90575a8b599 Mon Sep 17 00:00:00 2001 From: Andrew Keesler Date: Thu, 22 Jul 2021 10:25:40 -0400 Subject: [PATCH 4/4] SQUASH: update implementation history Signed-off-by: Andrew Keesler --- keps/sig-auth/541-external-credential-providers/README.md | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/keps/sig-auth/541-external-credential-providers/README.md b/keps/sig-auth/541-external-credential-providers/README.md index 80afcc5a763..31e3a6a12d4 100644 --- a/keps/sig-auth/541-external-credential-providers/README.md +++ b/keps/sig-auth/541-external-credential-providers/README.md @@ -910,5 +910,10 @@ _This section must be completed when targeting beta graduation to a release._ - 2018-01-29: Proposal submitted https://github.com/kubernetes/community/pull/1503 - 2018-02-28: Alpha (v1.10) implemented https://github.com/kubernetes/kubernetes/pull/59495 - 2018-06-04: Promoted to Beta (v1.11) https://github.com/kubernetes/kubernetes/pull/64482 -- 2021-05-11: Stable API approved https://github.com/kubernetes/enhancements/pull/2587 +- 2019-11-22: `rest_client_exec_plugin_ttl_seconds` and `rest_client_exec_plugin_certificate_rotation_age` metrics added (v1.18) https://github.com/kubernetes/kubernetes/pull/84382 +- 2020-07-09: `InstallHint` added to Beta API (v1.19) https://github.com/kubernetes/kubernetes/pull/91305 +- 2020-10-29: `ProvideClusterInfo` added to Beta API (v1.20) https://github.com/kubernetes/kubernetes/pull/95489 +- 2021-03-04: `rest_client_exec_plugin_call_total` metric added (v1.21) https://github.com/kubernetes/kubernetes/pull/98892 +- 2021-06-15: `InteractiveMode` added to Beta API (v1.22) https://github.com/kubernetes/kubernetes/pull/99310 +- 2021-05-11: Stable API approved (v1.22) https://github.com/kubernetes/enhancements/pull/2587 - 2021-07-06: Promoted to Stable (v1.22) https://github.com/kubernetes/kubernetes/pull/102890