-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebSocket protocol support #205
Comments
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale Not stale, but also not for v1alpha1. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle rotten |
Any progress on this? Seems like an essential feature. |
There's been no progress that I'm personally aware of. If you have a strong interest and use case it might be worth joining the monday night community meeting and bringing this one up for discussion 🤔 |
So as it turns out, there's some discussion about this going on in #1244. I'm going to mark this as |
Given that this has been marked help wanted for a long time without anyone with a strong interest to champion it and move it forward, it doesn't seem like we've got any momentum behind this currently. As such we'll consider this closed as "not planned" for the moment. This doesn't mean we'll never do it it just means it doesn't currently have any priority: if you're interested in taking this issue on and moving it forward please comment here and we would be happy to re-open it. |
@shaneutt this falls under the backend properties https://gateway-api.sigs.k8s.io/geps/gep-1282/ I would reopen this |
/reopen |
@dprotaso: Reopened this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
some implementations like Envoy Gateway and Istio have web socket upgrade enabled by default for HTTP 1.1 |
@dprotaso are you specifically interested in driving this forward, may we assign you? |
Yup please do - I'm going to try tackling specifying backend protocol which would cover this |
Awesome, thank you! Let us know how we can support you in your efforts 🖖 /assign @dprotaso |
We want this feature, but just a heads up @dprotaso we consider it low priority until |
I'm hoping this can be covered by - #1911 |
For those following I created a GEP PR that I believe would #1979 address this issue. PTAL with and leave comments. |
From the GEP-1911 discussion folks seem onboard with using the K8s |
This issue is closely related to #204.
There should be a way for applications to indicate that they want WebSocket streams for HTTP/1.1 or HTTP/2.
One way to do this could be a
WebSocketRoute
as a peer toHTTPRoute
. Another way cold be to add a field somewhere under theHTTPRoute
API.Some ingress controllers implement this by a flag on the HTTP virtual host or forwarding route (e.g. Contour puts it on the Route).
The text was updated successfully, but these errors were encountered: