Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS error in FuseIndex:_addObject/isBlank #661

Closed
codeflow-biz opened this issue May 10, 2022 · 1 comment · May be fixed by usernamerandom11/JokeAPI#38 or usernamerandom11/JokeAPI#39
Closed

JS error in FuseIndex:_addObject/isBlank #661

codeflow-biz opened this issue May 10, 2022 · 1 comment · May be fixed by usernamerandom11/JokeAPI#38 or usernamerandom11/JokeAPI#39
Labels

Comments

@codeflow-biz
Copy link

Describe the bug

In FuseIndex.js:132 / _addObject function (the elseif condition if the code line has changed). If the "value" variable contains an (empty) object, the isBlank function is called and then a js error (value.trim() is not defined) is raised.

I guess the elseif condition should just be changed to "(isString(value) && !isBlank(value))" like it is a few rows above in the if block.

Version

latest (6.6.1)

🔬Minimal Reproduction

Goto https://choices-js.github.io/Choices/ and scroll down to the dropdown with "data-custom-properties" example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment