MTA-1320: Only create discovery dir for test #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emily McMullan <emcmulla@redhat.com>
|
Overall success rate: 80.29% (1898/2364) |
fabianvf
requested changes
Oct 18, 2023
pkg/conversion/convert.go
Outdated
| err := writeDiscoveryRules(outputDir) | ||
| if err != nil { | ||
| return nil, err | ||
| func ConvertWindupRulesetsToAnalyzer(windups []windup.Ruleset, baseLocation, outputDir string, flattenRulesets bool, cmd string) (map[string]*analyzerRules, error) { |
There was a problem hiding this comment.
Could we just make this argument something like writeDiscoveryRules rather than making it aware of the subcommand running it?
Signed-off-by: Emily McMullan <emcmulla@redhat.com>
eemcmullan
changed the title
fabianvf
approved these changes
Oct 25, 2023
This was referenced Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.