🐛 Prefer Task field kind over addon
#1971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Replaces #1959 |
ibolton336
approved these changes
Jun 20, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1971 +/- ##
==========================================
+ Coverage 39.20% 42.22% +3.01%
==========================================
Files 146 170 +24
Lines 4857 5450 +593
Branches 1164 1387 +223
==========================================
+ Hits 1904 2301 +397
- Misses 2939 3032 +93
- Partials 14 117 +103
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Resolves: konveyor#1970 - When creating a new `Taskgroup`, specify `kind` instead of `addon` - Process Tasks where `kind` may be missing and `addon` is given instead (tasks created before this change) - Make `Task.id` and `Taskgroup.id` required, `New<>` as needed Signed-off-by: Ian Bolton <ibolton@redhat.com> Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
This was referenced Jun 22, 2024
This was referenced Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #1970
When creating a new
Taskgroup, specifykindinstead ofaddonProcess Tasks where
kindmay be missing andaddonis given instead (i.e. tasks created before this change)Make
Task.idandTaskgroup.idrequired,New<>as needed