🐛 Update external links styling across the UI #1602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves: https://issues.redhat.com/browse/MTA-1846 Update the render of external links to be consistent across the UI: - Use `ExternalLink` consistently - The icon used is the small size of `ExternalLinkAltIcon` - The text and the icon are both part of the link Use of `ExternalLink` updated to use the inline variant when used directly in table cells so it doesn't introduce extra height to the row. In a `td`, we want text and link content to be the same height. Use updated in: - Dependencies detail drawer, application table, version link - Issues table, expanded row, details links - Migration waves, status sub-table, issue link Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
|
Screenshots of external link use in dependencies and issues tables:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1602 +/- ##
=======================================
Coverage 39.27% 39.27%
=======================================
Files 146 146
Lines 4827 4827
Branches 1152 1152
=======================================
Hits 1896 1896
Misses 2917 2917
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This was referenced Dec 11, 2023
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://issues.redhat.com/browse/MTA-1846
Update the render of external links to be consistent across the UI:
ExternalLinkconsistentlyExternalLinkAltIconUse of
ExternalLinkupdated to use the inline variant when used directly in table cells so it doesn't introduce extra height to the row. In atd, we want text and link content to be the same height.Use updated in: