Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add question mark icon for archetype assessed indicator #1561

Merged
merged 7 commits into from
Nov 23, 2023

Conversation

ibolton336
Copy link
Member

Signed-off-by: ibolton336 <ibolton@redhat.com>
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (375db82) 39.41% compared to head (303f189) 39.41%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1561   +/-   ##
=======================================
  Coverage   39.41%   39.41%           
=======================================
  Files         146      146           
  Lines        4775     4775           
  Branches     1138     1138           
=======================================
  Hits         1882     1882           
  Misses       2879     2879           
  Partials       14       14           
Flag Coverage Δ
client 39.41% <ø> (ø)
server ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is a bit off with the layout on the infotip icon:
screenshot-localhost_9000-2023 11 21-17_24_21

Signed-off-by: ibolton336 <ibolton@redhat.com>
Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks ok.

The layout still overlaps when the browser window width is less than 1750px:
Screenshot from 2023-11-22 10-08-51

This change is ok, but I do think there are more effective ways to handling displaying the "Not Started" vs "Completed via inheritance from an archetype" vs "Completed assemment/review direct against the application". Maybe text values of "Not Started", "Inherited", "Completed" or "Not Started", "From Archetype", "Completed"? That can be a followup issue.

Signed-off-by: ibolton336 <ibolton@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants