✨ Override review confirmation & drawer updates #1527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ibolton336
commented
Nov 8, 2023
•
ibolton336
commented
- Adds review override as discussed in the Tuesday UXD call
- Shows either the app level review if it exists or the matched archetype reviews in the app drawer review tab - not both.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1527 +/- ##
=======================================
Coverage 40.65% 40.65%
=======================================
Files 145 145
Lines 4607 4607
Branches 1077 1077
=======================================
Hits 1873 1873
Misses 2720 2720
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
https://issues.redhat.com/browse/MTA-1330 --------- Signed-off-by: ibolton336 <ibolton@redhat.com>
Only show archetype review if no app review Signed-off-by: ibolton336 <ibolton@redhat.com>
ibolton336
force-pushed
the
confirm-override-review
branch
from
24d6d87
to
43913f5
Compare
ibolton336
added
the
priority/release-blocker
This was referenced Nov 22, 2023
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.