Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix stale wizard state when navigating between assessments #1484

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

ibolton336
Copy link
Member

  • Fixes an issue previously worked around by refreshing the sections when the assessment was being fetched. This can be solved by conditional rendering the entire wizard.
  • Removes old isOpen props & state
  • Fixes retake by removing a history.push to the previous assessment.id
  • Adds an error alert to indicate a failed assessment fetch

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (a7d5d84) 40.69% compared to head (79a0bc0) 40.69%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1484   +/-   ##
=======================================
  Coverage   40.69%   40.69%           
=======================================
  Files         139      139           
  Lines        4463     4463           
  Branches     1067     1067           
=======================================
  Hits         1816     1816           
  Misses       2552     2552           
  Partials       95       95           
Flag Coverage Δ
client 40.69% <ø> (ø)
server ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: ibolton336 <ibolton@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants