Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Dedupe tags when selecting in app form #1454

Merged
merged 2 commits into from
Oct 11, 2023

Conversation

ibolton336
Copy link
Member

  • Adds a util function for deduping items objects of a generic type) in an array
  • Uses the util function to dedupe tags when selecting from the applications form tags

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (82de730) 40.97% compared to head (f0452b7) 40.99%.
Report is 2 commits behind head on main.

❗ Current head f0452b7 differs from pull request most recent head acdec2d. Consider uploading reports for the commit acdec2d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1454      +/-   ##
==========================================
+ Coverage   40.97%   40.99%   +0.02%     
==========================================
  Files         139      139              
  Lines        4430     4440      +10     
  Branches     1015     1016       +1     
==========================================
+ Hits         1815     1820       +5     
- Misses       2603     2608       +5     
  Partials       12       12              
Flag Coverage Δ
client 40.99% <54.54%> (+0.02%) ⬆️
server ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...s/components/application-form/application-form.tsx 66.31% <100.00%> (+0.36%) ⬆️
client/src/app/utils/utils.ts 65.75% <37.50%> (-3.48%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: ibolton336 <ibolton@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant