🐛 Fix broken tag colors by moving LabelCustomColor from lib-ui and updating it for PF5 #1431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dating it for PF5 Signed-off-by: Mike Turley <mike.turley@alum.cs.umass.edu>
ibolton336
approved these changes
Oct 4, 2023
This was referenced Nov 22, 2023
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the
LabelCustomColorcomponent into this repo from https://github.com/migtools/lib-ui and updates the CSS variable names it uses to include thepf-v5-c-*version prefix that is new in PF5. This fixes the tags in the app inventory page losing their colors in the PF5 upgrade.See migtools/lib-ui#141 for the corresponding removal from lib-ui.
Before:
After:
