🐛 Assessment settings table columns empty #1391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibolton336
force-pushed
the
assessment-settings-table-cols
branch
from
e9ef638
to
d567a24
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1391 +/- ##
=======================================
Coverage 41.31% 41.31%
=======================================
Files 138 138
Lines 4330 4330
Branches 1035 1035
=======================================
Hits 1789 1789
Misses 2453 2453
Partials 88 88
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
sjd78
reviewed
Sep 25, 2023
client/src/app/pages/assessment-management/assessment-settings/assessment-settings-page.tsx
Outdated
Show resolved
Hide resolved
client/src/app/pages/assessment-management/assessment-settings/assessment-settings-page.tsx
Outdated
Show resolved
Hide resolved
client/src/app/pages/assessment-management/assessment-settings/assessment-settings-page.tsx
Outdated
Show resolved
Hide resolved
| > | ||
| {questionnaire.dateImported} | ||
| {formattedDate} |
There was a problem hiding this comment.
Another good candidate for a helper component.
ibolton336
force-pushed
the
assessment-settings-table-cols
branch
from
598438b
to
8ae3892
Compare
Signed-off-by: ibolton336 <ibolton@redhat.com>
ibolton336
force-pushed
the
assessment-settings-table-cols
branch
from
096fa6f
to
65eeaeb
Compare
This was referenced Nov 22, 2023
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://issues.redhat.com/browse/MTA-1317
This pull request addresses the issue of empty columns in the Assessment settings table by making the following changes:
Updated Models: Modified the Questionnaire model in client/src/app/api/models.ts to include the createTime field, which is now used for the "Date imported" column in the Assessment settings table.
Date Formatting: Utilized the dayjs library to format the date from the createTime field into a human-readable format ("YYYY-MM-DD HH:mm:ss") for display in the table.
Thresholds Display: Modified the rendering of thresholds in the "Rating" column to display each color and its percentage.
These changes should resolve the issue of empty columns and ensure that the table displays the relevant data correctly.