Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix missing variant for dropdown #1369

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

ibolton336
Copy link
Member

@ibolton336 ibolton336 commented Sep 15, 2023

  • Addresses missing default value in the credential dropdown for analysis wizard

Without variant

image

With variant
Screenshot 2023-09-15 at 1 24 26 PM

Signed-off-by: ibolton336 <ibolton@redhat.com>
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b870fae) 41.43% compared to head (7b4894b) 41.43%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1369   +/-   ##
=======================================
  Coverage   41.43%   41.43%           
=======================================
  Files         137      137           
  Lines        4279     4279           
  Branches     1026     1026           
=======================================
  Hits         1773     1773           
  Misses       2418     2418           
  Partials       88       88           
Flag Coverage Δ
client 41.43% <ø> (ø)
server ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ages/applications/analysis-wizard/custom-rules.tsx 15.27% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants