✨ Show the name of objects to be deleted in the confirm delete modals #1347
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies the pattern from #1333 to the rest of our entity delete confirmation modals.
Note that in order to do this, I needed to refactor away an inconsistent pattern: Some of our delete modals were kept track of with
thingIdToDelete
as a number in state andisConfirmDialogOpen
as a boolean. In order to show the name in the confirm modal, this PR refactors these incidences to store a reference to the whole objectthingToDelete
instead of just the id. TheisConfirmDialogOpen
state was also redundant because the confirm modal is always closed whenthingToDelete
is falsy and open when it's truthy, so this PR also removes those booleans from state and usesthingToDelete
as the source of truth.