Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Update validation method for forms to validate onBlur & onChange #1310

Merged
merged 2 commits into from
Aug 24, 2023

Conversation

ibolton336
Copy link
Member

Signed-off-by: ibolton336 <ibolton@redhat.com>
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Patch coverage: 61.11% and project coverage change: +0.07% 🎉

Comparison is base (8ce3163) 42.96% compared to head (4ec3830) 43.04%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1310      +/-   ##
==========================================
+ Coverage   42.96%   43.04%   +0.07%     
==========================================
  Files         144      145       +1     
  Lines        4317     4330      +13     
  Branches      999      999              
==========================================
+ Hits         1855     1864       +9     
- Misses       2381     2454      +73     
+ Partials       81       12      -69     
Flag Coverage Δ
client 43.04% <61.11%> (+0.07%) ⬆️
server ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
client/src/app/components/StringListField.tsx 31.57% <ø> (ø)
...s/applications/analysis-wizard/analysis-wizard.tsx 64.16% <ø> (ø)
...pages/applications/analysis-wizard/set-options.tsx 16.32% <ø> (ø)
...s/components/application-form/application-form.tsx 55.39% <ø> (ø)
...ntities/components/identity-form/identity-form.tsx 55.87% <ø> (ø)
client/src/app/pages/proxies/proxy-form.tsx 36.29% <ø> (ø)
client/src/app/queries/applications.ts 46.77% <36.36%> (-2.25%) ⬇️
client/src/app/Paths.ts 90.69% <100.00%> (+0.22%) ⬆️
...nts/HookFormPFFields/HookFormPFGroupController.tsx 100.00% <100.00%> (+14.28%) ⬆️
...components/HookFormPFFields/HookFormPFTextArea.tsx 85.71% <100.00%> (ø)
... and 3 more

... and 23 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants