Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Add taskgroup when uploading binary #1280

Merged
merged 2 commits into from
Aug 17, 2023

Conversation

ibolton336
Copy link
Member

@ibolton336 ibolton336 commented Aug 10, 2023

@ibolton336 ibolton336 force-pushed the binary-fix branch 2 times, most recently from b4566bb to b9eeb08 Compare August 10, 2023 23:40
@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Patch coverage: 29.16% and project coverage change: -0.14% ⚠️

Comparison is base (435b73a) 43.09% compared to head (f0ed7a4) 42.96%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1280      +/-   ##
==========================================
- Coverage   43.09%   42.96%   -0.14%     
==========================================
  Files         143      144       +1     
  Lines        4297     4317      +20     
  Branches      998      999       +1     
==========================================
+ Hits         1852     1855       +3     
- Misses       2364     2381      +17     
  Partials       81       81              
Flag Coverage Δ
client 42.96% <29.16%> (-0.14%) ⬇️
server ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...tions/analysis-wizard/components/upload-binary.tsx 13.18% <15.00%> (-0.33%) ⬇️
...s/applications/analysis-wizard/analysis-wizard.tsx 64.16% <25.00%> (+1.17%) ⬆️
...ns/analysis-wizard/components/TaskGroupContext.tsx 40.00% <40.00%> (ø)
...ages/applications/analysis-wizard/custom-rules.tsx 15.27% <50.00%> (+0.48%) ⬆️
...pp/pages/applications/analysis-wizard/set-mode.tsx 86.20% <100.00%> (+2.33%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: ibolton336 <ibolton@redhat.com>
@@ -92,7 +92,7 @@ export const CustomRules: React.FC<CustomRulesProps> = (props) => {
successfullyReadFileCount,
handleFile,
removeFiles,
} = useRuleFiles(props?.taskgroupID, values.customRulesFiles);
} = useRuleFiles(taskGroup?.id, values.customRulesFiles);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only bit that looks suspicious to me under brain compile.

What happens if the taskGroup changes? Maybe something like from undefined to { id: 5 }?

I'll run through some smoke tests in a bit. Maybe that will clear up my confusion.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Fair concern. The taskgroup should always exist by the time the user arrives at the custom-rules step as it is created either 1) when onMove to step 2 of the wizard or 2) user uploads a binary on step 1 of the wizard.

Copy link
Member

@sjd78 sjd78 Aug 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@sjd78 sjd78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants