-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Add taskgroup when uploading binary #1280
Conversation
b4566bb
to
b9eeb08
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1280 +/- ##
==========================================
- Coverage 43.09% 42.96% -0.14%
==========================================
Files 143 144 +1
Lines 4297 4317 +20
Branches 998 999 +1
==========================================
+ Hits 1852 1855 +3
- Misses 2364 2381 +17
Partials 81 81
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
4f33367
to
d682394
Compare
Signed-off-by: ibolton336 <ibolton@redhat.com>
@@ -92,7 +92,7 @@ export const CustomRules: React.FC<CustomRulesProps> = (props) => { | |||
successfullyReadFileCount, | |||
handleFile, | |||
removeFiles, | |||
} = useRuleFiles(props?.taskgroupID, values.customRulesFiles); | |||
} = useRuleFiles(taskGroup?.id, values.customRulesFiles); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only bit that looks suspicious to me under brain compile.
What happens if the taskGroup changes? Maybe something like from undefined
to { id: 5 }
?
I'll run through some smoke tests in a bit. Maybe that will clear up my confusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://react.dev/learn/reusing-logic-with-custom-hooks#passing-reactive-values-between-hooks
Ok so I'm not concerned about that anymore. 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolves https://issues.redhat.com/browse/MTA-1175