✨ Proxies: rest queries and notifications #1240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gildub
changed the title
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1240 +/- ##
==========================================
+ Coverage 44.03% 44.04% +0.01%
==========================================
Files 177 177
Lines 4524 4516 -8
Branches 1009 1038 +29
==========================================
- Hits 1992 1989 -3
+ Misses 2521 2452 -69
- Partials 11 75 +64
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
ibolton336
reviewed
Aug 2, 2023
client/src/app/queries/proxies.ts
Outdated
| export const useUpdateProxyMutation = (onSuccess: any) => { | ||
| const [putResult, setPutResult] = useState<any>(null); | ||
| export const useUpdateProxyMutation = ( | ||
| onSuccess: (res: any) => void, |
There was a problem hiding this comment.
Let's add a type here for the response if it is needed.
ibolton336
reviewed
Aug 2, 2023
| @@ -309,22 +309,6 @@ export const deleteIdentity = (identity: Identity): AxiosPromise => { | |||
| return APIClient.delete(`${IDENTITIES}/${identity.id}`); | |||
| }; | |||
|
|
|||
| export const getProxies = (): AxiosPromise<Array<Proxy>> => { | |||
| return APIClient.get(`${PROXIES}`, jsonHeaders); | |||
ibolton336
requested changes
Aug 2, 2023
ibolton336
approved these changes
Aug 3, 2023
Signed-off-by: Gilles Dubreuil <gdubreui@redhat.com>
Signed-off-by: Gilles Dubreuil <gdubreui@redhat.com>
This was referenced Nov 22, 2023
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In continuation of work already done to align, feature by feature, here the proxy configuration to :
instead forAlert`.