🐛 Hide hidden rulesets from seeded hub list #1205
Conversation
ibolton336
force-pushed
the
hide-hidden-rulesets
branch
from
8bcefa9
to
59e8e1e
Compare
client/src/app/queries/rulesets.ts
Outdated
| }); | ||
| return { ...ruleset, rules: mappedRules }; | ||
| }) | ||
| .filter((ruleset) => !ruleset.name.startsWith(".")); |
There was a problem hiding this comment.
Adds this filter for hidden rulesets.
| const matchingRuleset = rulesets.find( | ||
| (Ruleset) => Ruleset.id === id | ||
| ); | ||
| if (matchingRuleset) { |
There was a problem hiding this comment.
Don't display ordered items which are hidden.
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1205 +/- ##
=======================================
Coverage 44.09% 44.10%
=======================================
Files 177 177
Lines 4511 4501 -10
Branches 1006 1006
=======================================
- Hits 1989 1985 -4
+ Misses 2511 2505 -6
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
The system owned resource is hidden in the Administration -> Custom migration targets page but there is a blank target showing in the Set Targets during Application analysis.
The concern is a succession of blank targets pushing everything down in case when there are several hidden targets:
Good catch. The blank targets are filtered in the migration targets page, but not in the wizard. Should be fixed now! |
ibolton336
force-pushed
the
hide-hidden-rulesets
branch
from
8bc27b5
to
62a963e
Compare
client/src/app/queries/rulesets.ts
Outdated
| }); | ||
| return { ...ruleset, rules: mappedRules }; | ||
| }) | ||
| .filter((ruleset) => !ruleset.name.startsWith(".")); |
There was a problem hiding this comment.
Very very minor nit-pick: I suggest moving the filter() above the map() so the map() only needs to process things that will end up being selected.
Signed-off-by: ibolton336 <ibolton@redhat.com>
ibolton336
force-pushed
the
hide-hidden-rulesets
branch
from
62a963e
to
c130a05
Compare
Resolves #1093