Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Add missing icon & fix open/close state #1158

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

ibolton336
Copy link
Member

  • Fix CodeEditor modal open/close state when viewing a completed analysis.

Signed-off-by: ibolton336 <ibolton@redhat.com>
@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (a18d5ba) 44.09% compared to head (c7bc1f0) 44.09%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1158   +/-   ##
=======================================
  Coverage   44.09%   44.09%           
=======================================
  Files         177      177           
  Lines        4499     4499           
  Branches     1007     1007           
=======================================
  Hits         1984     1984           
  Misses       2504     2504           
  Partials       11       11           
Flag Coverage Δ
unitests 44.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ibolton336 ibolton336 merged commit 0b20ab3 into konveyor:main Jul 18, 2023
7 checks passed
@ibolton336 ibolton336 deleted the report-warning branch July 18, 2023 20:33
ibolton336 added a commit to ibolton336/tackle2-ui that referenced this pull request Jul 21, 2023
- Fix CodeEditor modal open/close state when viewing a completed
analysis.

Signed-off-by: ibolton336 <ibolton@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants