Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Use latest prerelease version for PF V5 #1155

Merged
merged 2 commits into from
Jul 19, 2023
Merged

✨ Use latest prerelease version for PF V5 #1155

merged 2 commits into from
Jul 19, 2023

Conversation

gildub
Copy link
Contributor

@gildub gildub commented Jul 18, 2023

The prerelease version stanza pull the latest prerelease versions of PF allowing us to not have to update those dependencies every couple of days as this is moving quite fast.

@gildub gildub self-assigned this Jul 18, 2023
@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (0b20ab3) 44.09% compared to head (cb9953c) 44.09%.

❗ Current head cb9953c differs from pull request most recent head 446aab6. Consider uploading reports for the commit 446aab6 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1155   +/-   ##
=======================================
  Coverage   44.09%   44.09%           
=======================================
  Files         177      177           
  Lines        4499     4499           
  Branches     1007     1007           
=======================================
  Hits         1984     1984           
  Misses       2504     2504           
  Partials       11       11           
Flag Coverage Δ
unitests 44.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Comment on lines 24 to 29
"@patternfly/patternfly": "prerelease",
"@patternfly/react-charts": "prerelease",
"@patternfly/react-code-editor": "prerelease",
"@patternfly/react-core": "prerelease",
"@patternfly/react-table": "prerelease",
"@patternfly/react-tokens": "prerelease",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the PF guys meant "^5.0.0-prerelease" to get the latest prerelease versions.

From the semver docs:

^1.2.3-beta.2 := >=1.2.3-beta.2 <2.0.0-0 Note that prereleases in the 1.2.3 version will be allowed, if they are greater than or equal to beta.2. So, 1.2.3-beta.4 would be allowed, but 1.2.4-beta.2 would not, because it is a prerelease of a different [major, minor, patch] tuple.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gildub gildub requested a review from sjd78 July 18, 2023 13:39
Signed-off-by: Gilles Dubreuil <gdubreui@redhat.com>
Signed-off-by: Gilles Dubreuil <gdubreui@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants