Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Remove empty name column for issues in favor of description column #1152

Merged
merged 2 commits into from
Jul 17, 2023
Merged

✨ Remove empty name column for issues in favor of description column #1152

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dde7826
:sparkles: Remove empty name column for issues in favor of descriptio…
mturley Jul 17, 2023
4e98244
Merge branch 'main' into remove-issue-name-column
mturley Jul 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 6 additions & 15 deletions client/src/app/pages/issues/issues-table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,17 +99,16 @@ export const IssuesTable: React.FC<IIssuesTableProps> = ({ mode }) => {
const tableControlState = useTableControlUrlParams({
urlParamKeyPrefix: TableURLParamKeyPrefix.issues,
columnNames: {
name: "Issue",
description: "Description",
description: "Issue",
category: "Category",
source: "Source",
target: "Target(s)",
effort: "Effort",
affected:
mode === "singleApp" ? "Affected files" : "Affected applications",
},
sortableColumns: ["name", "category", "effort", "affected"],
initialSort: { columnKey: "name", direction: "asc" },
sortableColumns: ["description", "category", "effort", "affected"],
initialSort: { columnKey: "description", direction: "asc" },
filterCategories: [
...(mode === "allIssues" ? allIssuesSpecificFilterCategories : []),
{
Expand Down Expand Up @@ -171,7 +170,7 @@ export const IssuesTable: React.FC<IIssuesTableProps> = ({ mode }) => {
const hubRequestParams = getHubRequestParams({
...tableControlState, // Includes filterState, sortState and paginationState
hubSortFieldKeys: {
name: "name",
description: "description",
category: "category",
effort: "effort",
affected: mode === "singleApp" ? "files" : "applications",
Expand Down Expand Up @@ -309,7 +308,6 @@ export const IssuesTable: React.FC<IIssuesTableProps> = ({ mode }) => {
<Thead>
<Tr>
<TableHeaderContentWithControls {...tableControls}>
<Th {...getThProps({ columnKey: "name" })} />
<Th {...getThProps({ columnKey: "description" })} />
<Th {...getThProps({ columnKey: "category" })} />
<Th {...getThProps({ columnKey: "source" })} />
Expand Down Expand Up @@ -354,20 +352,13 @@ export const IssuesTable: React.FC<IIssuesTableProps> = ({ mode }) => {
rowIndex={rowIndex}
>
<Td
width={15}
{...getTdProps({ columnKey: "name" })}
modifier="truncate"
>
{report.name}
</Td>
<Td
width={25}
width={30}
{...getTdProps({ columnKey: "description" })}
modifier="truncate"
>
{report.description.split("\n")[0]}
</Td>
<Td width={10} {...getTdProps({ columnKey: "category" })}>
<Td width={20} {...getTdProps({ columnKey: "category" })}>
{report.category}
</Td>
<Td
Expand Down
Loading