🐛 Fix mismatched new/deprecated dropdown components in KebabDropdown #1126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mike Turley <mike.turley@alum.cs.umass.edu>
ibolton336
approved these changes
Jul 12, 2023
mturley
added a commit
to mturley/tackle2-ui
that referenced
this pull request
Jul 17, 2023
…babDropdown (konveyor#1126)" This reverts commit e35086b.
mturley
added a commit
to mturley/tackle2-ui
that referenced
this pull request
Jul 17, 2023
…babDropdown (konveyor#1126)" This reverts commit e35086b. Signed-off-by: Mike Turley <mike.turley@alum.cs.umass.edu>
gildub
pushed a commit
that referenced
this pull request
Jul 17, 2023
…ecated `DropdownItems`, use `isAriaDisabled` prop for items with tooltips (#1150) Fixes a regression caused by #1126 where dropdown items that are disabled with tooltips could not trigger the tooltips. Discovered by @gildub when working on #1149. It appears the `isAriaDisabled` prop which we need for retaining the mouse hover event on a disabled DropdownItem is not present in the new PF5 DropdownItem. This is due to missing styles in PF core that are still being addressed (see patternfly/patternfly#5528, patternfly/patternfly#5692, and related comment here: patternfly/patternfly-react#8992 (comment)) Until `isAriaDisabled` is supported in the new PF5 DropdownItem we must restore the usage of the deprecated component for these tooltips to work.
This was referenced Nov 22, 2023
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1125
We were using the old Dropdown component from
@patternfly/react-core/deprecatedwith the new DropdownItem component from@patternfly/react-core. This change upgrades our sharedKebabDropdownto use the new PF5Dropdownstructure.