-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Issues table: Add description column, render expanded description as markdown, render links under markdown in table and incident viewer, add alert text to all incidents tab #1116
Conversation
Signed-off-by: Mike Turley <mike.turley@alum.cs.umass.edu>
Signed-off-by: Mike Turley <mike.turley@alum.cs.umass.edu>
a09769f
to
386873c
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1116 +/- ##
=======================================
Coverage 44.08% 44.08%
=======================================
Files 177 177
Lines 4498 4498
Branches 1007 1007
=======================================
Hits 1983 1983
Misses 2504 2504
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Mike Turley <mike.turley@alum.cs.umass.edu>
386873c
to
22f39df
Compare
Signed-off-by: Mike Turley <mike.turley@alum.cs.umass.edu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Mike Turley <mike.turley@alum.cs.umass.edu>
…ing issue name (#1186) Followup to #1116 When we replaced the issue name property (possibly empty in real data) with the truncated issue description in the table, we failed to replace it everywhere else it is used. This change uses the first line of the issue/report description where necessary, and truncates it with a tooltip in places with limited available width in case it is a long line. --------- Signed-off-by: Mike Turley <mike.turley@alum.cs.umass.edu>
This PR contains four presentation tweaks to the Issues page from recent discussions:
links
array that we were not rendering. This change adds external links for these URLs under the issue description in the expanded rows of the issues table, and under the incident message in the incident viewer modal.