Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Allow the select and multiselect filter controls to scroll content #1094

Merged
merged 2 commits into from
Jul 10, 2023
Merged

🐛 Allow the select and multiselect filter controls to scroll content #1094

merged 2 commits into from
Jul 10, 2023

Commits on Jul 10, 2023

  1. Allow the select and multiselect filter controls to scroll content 

    Add param `isScrollable`, and released css, to allow the patternfly
`Select` components at the core of `SelectFilterControl` and
`MultiselectFilterControl` to scroll its content as needed.  This
is a replication of the patternfly Menu `isScrollable` prop[1].

Summary of changes:
  - Add `isScrollable` (with a default value of `false`) to
    `SelectFilterControl` and `MultiselectFilterControl`

  - Add `select-overrides.css` to implement the scrolling for the
    components

  - Minor tweaks to the filter select controls to mirror code
    formatting as they are very similar components

Resolves: https://issues.redhat.com/browse/MTA-485
[1]: https://www.patternfly.org/v4/components/menu#scrollable-menus

Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
    @sjd78
    sjd78 committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    ca39640 View commit details
    Browse the repository at this point in the history

  2. Update to PF5 component CSS classnames 

    Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
    @sjd78
    sjd78 committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    d10c149 View commit details
    Browse the repository at this point in the history