🐛 Allow the select and multiselect filter controls to scroll content #1094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What it looked like before: What it looks like now: |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1094 +/- ##
==========================================
- Coverage 44.11% 44.10% -0.01%
==========================================
Files 177 177
Lines 4477 4487 +10
Branches 997 1001 +4
==========================================
+ Hits 1975 1979 +4
- Misses 2491 2497 +6
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
gildub
reviewed
Jul 6, 2023
sjd78
force-pushed
the
filter-controls-multiselect
branch
from
16aaebd
to
9a5178e
Compare
sjd78
force-pushed
the
filter-controls-multiselect
branch
from
9a5178e
to
adf271d
Compare
sjd78
force-pushed
the
filter-controls-multiselect
branch
2 times, most recently
from
b2da3bb
to
9c97e07
Compare
|
rebased and updated to work with PF5 |
|
The PF5 version of the Select component is built on the Menu component, so the Since we're still using the deprecated/PF4 component, the CSS overrides are still needed. |
Add param `isScrollable`, and released css, to allow the patternfly
`Select` components at the core of `SelectFilterControl` and
`MultiselectFilterControl` to scroll its content as needed. This
is a replication of the patternfly Menu `isScrollable` prop[1].
Summary of changes:
- Add `isScrollable` (with a default value of `false`) to
`SelectFilterControl` and `MultiselectFilterControl`
- Add `select-overrides.css` to implement the scrolling for the
components
- Minor tweaks to the filter select controls to mirror code
formatting as they are very similar components
Resolves: https://issues.redhat.com/browse/MTA-485
[1]: https://www.patternfly.org/v4/components/menu#scrollable-menus
Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
sjd78
force-pushed
the
filter-controls-multiselect
branch
from
9c97e07
to
d10c149
Compare
sjd78
added a commit
to sjd78/tackle2-ui
that referenced
this pull request
Jul 11, 2023
Add param `isScrollable`, and released css, to allow the patternfly `Select` components at the core of `SelectFilterControl` and `MultiselectFilterControl` to scroll its content as needed. This is a replication of the patternfly Menu `isScrollable` prop[1]. Summary of changes: - Add `isScrollable` (with a default value of `false`) to `SelectFilterControl` and `MultiselectFilterControl` - Add `select-overrides.css` to implement the scrolling for the components - Minor tweaks to the filter select controls to mirror code formatting as they are very similar components Backport of konveyor#1094 [1]: https://www.patternfly.org/v4/components/menu#scrollable-menus Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
sjd78
added a commit
that referenced
this pull request
Jul 11, 2023
…rols to scroll content (#1113) Add param `isScrollable`, and released css, to allow the patternfly `Select` components at the core of `SelectFilterControl` and `MultiselectFilterControl` to scroll its content as needed. This is a replication of the patternfly Menu `isScrollable` prop[1]. Summary of changes: - Add `isScrollable` (with a default value of `false`) to `SelectFilterControl` and `MultiselectFilterControl` - Add `select-overrides.css` to implement the scrolling for the components - Minor tweaks to the filter select controls to mirror code formatting as they are very similar components Backport of #1094 [1]: https://www.patternfly.org/v4/components/menu#scrollable-menus Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
This was referenced Nov 22, 2023
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add param
isScrollable, and released css, to allow the patternflySelectcomponents at the core ofSelectFilterControlandMultiselectFilterControlto scroll its content as needed. This is a replication of the patternfly MenuisScrollableprop[1].Summary of changes:
Add
isScrollable(with a default value offalse) toSelectFilterControlandMultiselectFilterControlAdd
select-overrides.cssto implement the scrolling for the componentsMinor tweaks to the filter select controls to mirror code formatting as they are very similar components
Resolves: https://issues.redhat.com/browse/MTA-485
[1]: https://www.patternfly.org/v4/components/menu#scrollable-menus